Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meta to Resource Identifier Objects #265

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+87 −34
Open

feat: add meta to Resource Identifier Objects #265

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37f2030
feat: add meta to Resource Identifier Objects
sl-ffx Apr 14, 2022
b95aacc
feat: add meta data if set
sl-ffx Jun 27, 2022
5bc24ad
fix: do not set relationships if no includes found
sl-ffx Jun 27, 2022
6f58407
test: fix test for last changes
sl-ffx Dec 20, 2023
54ea94a
feat: allow nested option typeForAttribute
sl-ffx Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix test for last changes
@sl-ffx
sl-ffx committed Dec 20, 2023

Verified

This commit was signed with the committer’s verified signature.
jkcdarunday Jan Keith Darunday
GPG key ID: A264AE9FA46D05B0
Verified
Learn about vigilant mode
commit 6f584077e40fbb10b9e777378041934b9af4e872
21 changes: 10 additions & 11 deletions test/deserializer.js
View file
Original file line number Diff line number Diff line change
@@ -478,7 +478,7 @@ describe('JSON API Deserializer', function () {
.deserialize(dataSet, function (err, json) {
expect(json).to.be.an('object');

expect(json).to.have.key('id', 'first-name', 'last-name',
expect(json).to.have.key('id', 'first-name', 'last-name',
'username', 'images');

expect(json.images).to.be.an('array').with.length(2)
@@ -553,7 +553,7 @@ describe('JSON API Deserializer', function () {
id: '2',
type: 'stores',
attributes: {
name: 'Fashionable Clothes'
name: 'Fashionable Clothes'
},
relationships: {
deals: {
@@ -619,7 +619,7 @@ describe('JSON API Deserializer', function () {
name: 'Twin Pines Mall',
id: '1',
stores: [
{
{
name: 'Tasty Food',
id: '1',
deals: [
@@ -634,10 +634,10 @@ describe('JSON API Deserializer', function () {
id: '2',
stores: [
{ name: 'Tasty Food', id: '1' }
]
}
]
}
]
}, {
}, {
name: 'Fashionable Clothes',
id: '2',
deals: [
@@ -649,10 +649,10 @@ describe('JSON API Deserializer', function () {
]
}
]
}, {
}, {
name: 'Readable Books',
id: '3'
}
}
],
deals: [
{
@@ -696,7 +696,7 @@ describe('JSON API Deserializer', function () {
}
]
}
]
]
});

done(null, json);
@@ -1180,8 +1180,7 @@ describe('JSON API Deserializer', function () {
expect(json).eql({
id: '54735750e16638ba1eee59cb',
'first-name': 'Sandro',
'last-name': 'Munda',
'addresses': []
'last-name': 'Munda'
});
done(null, json);
});