Add page-indicator carousel trigger button tokens#492
Merged
Gert-Jan Vercauteren (gert-janvercauteren) merged 2 commits intoApr 30, 2026
Merged
Conversation
Add PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER and PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER tokens used for the page-indicator carousel trigger button background. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Gert-Jan Vercauteren (gert-janvercauteren)
requested review from
a team
as code owners
Copilot started reviewing on behalf of
Gert-Jan Vercauteren (gert-janvercauteren)
April 30, 2026 02:40
View session
There was a problem hiding this comment.
Pull request overview
Adds new private color tokens for the page-indicator carousel trigger button background (default + hover), sourced from WHITE_ALPHA_50 and WHITE_ALPHA_80, and propagates them into generated token outputs for web, iOS, and Android.
Changes:
- Added a new token source file for page-indicator colors and wired it into the common color imports.
- Regenerated web token outputs (SCSS + JS/TS typings + raw JSON) to include the new tokens and a
pageIndicatorColorsexport group. - Regenerated iOS and Android raw token JSON outputs to include the new page-indicator tokens (including platform-specific
_COLORvariants where applicable).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/bpk-foundations-common/base/colors/page-indicator.json | New source definitions for page-indicator private color tokens. |
| packages/bpk-foundations-common/base/colors.json | Registers the new page-indicator color source file for token generation. |
| packages/bpk-foundations-web/tokens/base.raw.json | Adds the new page-indicator tokens to the web raw token output. |
| packages/bpk-foundations-web/tokens/base.scss | Adds generated SCSS variables for the new page-indicator tokens. |
| packages/bpk-foundations-web/tokens/base.default.scss | Adds generated defaulted SCSS variables for the new page-indicator tokens. |
| packages/bpk-foundations-web/tokens/base.es6.js | Exposes the new tokens in ES modules and adds a pageIndicatorColors grouping export. |
| packages/bpk-foundations-web/tokens/base.es6.d.ts | Updates TypeScript declarations to include the new tokens and pageIndicatorColors. |
| packages/bpk-foundations-web/tokens/base.common.js | Adds the new tokens to the CommonJS flat export map. |
| packages/bpk-foundations-ios/tokens/base.raw.ios.json | Adds the new page-indicator tokens to the iOS raw output (including _COLOR variants). |
| packages/bpk-foundations-ios/tokens/base.ios.json | Adds the new tokens to the iOS processed token list (camelCased names). |
| packages/bpk-foundations-android/tokens/base.raw.android.json | Adds the new page-indicator tokens to the Android raw output (including _COLOR variants). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use NORMAL/PRESSED background naming to align with component states. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Ezreal Yang (Supremeyh)
approved these changes
Apr 30, 2026
Gert-Jan Vercauteren (gert-janvercauteren)
merged commit 0773188
into
main
7 checks passed
Gert-Jan Vercauteren (gert-janvercauteren)
deleted the
gert-janvercauteren/page-indicator-tokens
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER(white-alpha-50) andPRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER(white-alpha-80) private tokens, used for the background of the carousel trigger button in the page-indicator component. New source file added atpackages/bpk-foundations-common/base/colors/page-indicator.json, with generated outputs updated across web, iOS, and Android packages.Remember to include the following changes: