Skip to content

Add page-indicator carousel trigger button tokens #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gert-Jan Vercauteren (gert-janvercauteren) merged 2 commits into from
Apr 30, 2026
Merged

Add page-indicator carousel trigger button tokens #492

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee241e
Add page-indicator carousel trigger button tokens
gert-janvercauteren Apr 30, 2026
ccee1a3
Rename page-indicator carousel button tokens
gert-janvercauteren Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 53 additions & 1 deletion packages/bpk-foundations-android/tokens/base.raw.android.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2842,6 +2842,34 @@
"originalValue": "{!NIGHT_SKY}",
"name": "PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_NIGHT"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT"
},
"ANIMATION_DURATION_XS": {
"type": "duration",
"value": "50ms",
Expand Down Expand Up @@ -3963,6 +3991,24 @@
"name": "PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_COLOR",
"darkValue": "#054184ff",
"originalDarkValue": "{!NIGHT_SKY}"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_COLOR": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_COLOR",
"darkValue": "#ffffff80",
"originalDarkValue": "{!WHITE_ALPHA_50}"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_COLOR": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_COLOR",
"darkValue": "#ffffffcc",
"originalDarkValue": "{!WHITE_ALPHA_80}"
}
},
"propKeys": [
Expand Down Expand Up @@ -4312,6 +4358,10 @@
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_NIGHT",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_DAY",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_NIGHT",
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY",
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT",
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY",
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT",
"ANIMATION_DURATION_XS",
"ANIMATION_DURATION_SM",
"ANIMATION_DURATION_BASE",
Expand Down Expand Up @@ -4445,6 +4495,8 @@
"PRIVATE_CARD_BUTTON_CONTAINED_FILL_COLOR",
"PRIVATE_SEGMENTED_CONTROL_CANVAS_DEFAULT_COLOR",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_COLOR",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_COLOR"
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_COLOR",
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_COLOR",
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_COLOR"
]
}
3 changes: 2 additions & 1 deletion packages/bpk-foundations-common/base/colors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"./colors/sponsored-banner.json",
"./colors/navigation-tab.json",
"./colors/card-button.json",
"./colors/segmented-control.json"
"./colors/segmented-control.json",
"./colors/page-indicator.json"
]
}
21 changes: 21 additions & 0 deletions packages/bpk-foundations-common/base/colors/page-indicator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"imports": ["./aliases.json"],
"global": {
"type": "color",
"category": "page-indicator-colors"
},
"props": {
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY": {
"value": "{!WHITE_ALPHA_50}"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT": {
"value": "{!WHITE_ALPHA_50}"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY": {
"value": "{!WHITE_ALPHA_80}"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT": {
Comment thread
gert-janvercauteren marked this conversation as resolved.
Outdated
"value": "{!WHITE_ALPHA_80}"
}
}
}
46 changes: 46 additions & 0 deletions packages/bpk-foundations-ios/tokens/base.ios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2477,6 +2477,34 @@
"originalValue": "{!NIGHT_SKY}",
"name": "privateSegmentedControlSurfaceContrastOnNight"
},
{
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "privatePageIndicatorBtnBgCarouselTriggerDay"
},
{
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "privatePageIndicatorBtnBgCarouselTriggerNight"
},
{
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "privatePageIndicatorBtnBgHoverCarouselTriggerDay"
},
{
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "privatePageIndicatorBtnBgHoverCarouselTriggerNight"
},
{
"type": "duration",
"value": "50ms",
Expand Down Expand Up @@ -3977,6 +4005,24 @@
"darkValue": "#054184ff",
"originalDarkValue": "{!NIGHT_SKY}"
},
{
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "privatePageIndicatorBtnBgCarouselTriggerColor",
"darkValue": "#ffffff80",
"originalDarkValue": "{!WHITE_ALPHA_50}"
},
{
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "privatePageIndicatorBtnBgHoverCarouselTriggerColor",
"darkValue": "#ffffffcc",
"originalDarkValue": "{!WHITE_ALPHA_80}"
},
{
"value": "#161616ff",
"type": "color",
Expand Down
52 changes: 52 additions & 0 deletions packages/bpk-foundations-ios/tokens/base.raw.ios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2854,6 +2854,34 @@
"originalValue": "{!NIGHT_SKY}",
"name": "PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_NIGHT"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT"
},
"ANIMATION_DURATION_XS": {
"type": "duration",
"value": "50ms",
Expand Down Expand Up @@ -4354,6 +4382,24 @@
"darkValue": "#054184ff",
"originalDarkValue": "{!NIGHT_SKY}"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_COLOR": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffff80",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_COLOR",
"darkValue": "#ffffff80",
"originalDarkValue": "{!WHITE_ALPHA_50}"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_COLOR": {
"type": "color",
"category": "page-indicator-colors",
"value": "#ffffffcc",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_COLOR",
"darkValue": "#ffffffcc",
"originalDarkValue": "{!WHITE_ALPHA_80}"
},
"SHADOW_COLOR": {
"value": "#161616ff",
"type": "color",
Expand Down Expand Up @@ -4711,6 +4757,10 @@
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_NIGHT",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_DAY",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_NIGHT",
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY",
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT",
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY",
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT",
"ANIMATION_DURATION_XS",
"ANIMATION_DURATION_SM",
"ANIMATION_DURATION_BASE",
Expand Down Expand Up @@ -4899,6 +4949,8 @@
"PRIVATE_SEGMENTED_CONTROL_CANVAS_DEFAULT_COLOR",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_COLOR",
"PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_COLOR",
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_COLOR",
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_COLOR",
"SHADOW_COLOR"
]
}
4 changes: 4 additions & 0 deletions packages/bpk-foundations-web/tokens/base.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,10 @@ module.exports = {
privateSegmentedControlSurfaceContrastNight: "rgb(19, 29, 43)",
privateSegmentedControlSurfaceContrastOnDay: "rgb(2, 77, 175)",
privateSegmentedControlSurfaceContrastOnNight: "rgb(5, 65, 132)",
privatePageIndicatorBtnBgCarouselTriggerDay: "rgba(255, 255, 255, 0.5)",
privatePageIndicatorBtnBgCarouselTriggerNight: "rgba(255, 255, 255, 0.5)",
privatePageIndicatorBtnBgHoverCarouselTriggerDay: "rgba(255, 255, 255, 0.8)",
privatePageIndicatorBtnBgHoverCarouselTriggerNight: "rgba(255, 255, 255, 0.8)",
colorSkyBlueShade03: "rgb(2, 18, 44)",
colorPrimaryGradientLight: "rgb(0, 98, 227)",
colorErfoud: "rgb(255, 181, 77)",
Expand Down
8 changes: 8 additions & 0 deletions packages/bpk-foundations-web/tokens/base.default.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,14 @@ $bpk-private-segmented-control-surface-contrast-night: rgb(19, 29, 43) !default;
$bpk-private-segmented-control-surface-contrast-on-day: rgb(2, 77, 175) !default;
/// @group segmented-control-colors
$bpk-private-segmented-control-surface-contrast-on-night: rgb(5, 65, 132) !default;
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-carousel-trigger-day: rgba(255, 255, 255, 0.5) !default;
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-carousel-trigger-night: rgba(255, 255, 255, 0.5) !default;
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-hover-carousel-trigger-day: rgba(255, 255, 255, 0.8) !default;
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-hover-carousel-trigger-night: rgba(255, 255, 255, 0.8) !default;
/// @group colors
$bpk-color-sky-blue-shade-03: rgb(2, 18, 44) !default;
/// @group colors
Expand Down
10 changes: 10 additions & 0 deletions packages/bpk-foundations-web/tokens/base.es6.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@ export declare const privateSegmentedControlSurfaceContrastDay = "rgba(255, 255,
export declare const privateSegmentedControlSurfaceContrastNight = "rgb(19, 29, 43)" as const;
export declare const privateSegmentedControlSurfaceContrastOnDay = "rgb(2, 77, 175)" as const;
export declare const privateSegmentedControlSurfaceContrastOnNight = "rgb(5, 65, 132)" as const;
export declare const privatePageIndicatorBtnBgCarouselTriggerDay = "rgba(255, 255, 255, 0.5)" as const;
export declare const privatePageIndicatorBtnBgCarouselTriggerNight = "rgba(255, 255, 255, 0.5)" as const;
export declare const privatePageIndicatorBtnBgHoverCarouselTriggerDay = "rgba(255, 255, 255, 0.8)" as const;
export declare const privatePageIndicatorBtnBgHoverCarouselTriggerNight = "rgba(255, 255, 255, 0.8)" as const;
export declare const colorSkyBlueShade03 = "rgb(2, 18, 44)" as const;
export declare const colorPrimaryGradientLight = "rgb(0, 98, 227)" as const;
export declare const colorErfoud = "rgb(255, 181, 77)" as const;
Expand Down Expand Up @@ -746,6 +750,12 @@ export declare const overlayColors = {
overlayDay,
overlayNight,
} as const;
export declare const pageIndicatorColors = {
privatePageIndicatorBtnBgCarouselTriggerDay,
privatePageIndicatorBtnBgCarouselTriggerNight,
privatePageIndicatorBtnBgHoverCarouselTriggerDay,
privatePageIndicatorBtnBgHoverCarouselTriggerNight,
} as const;
export declare const panels = {
panelBorderColor,
} as const;
Expand Down
10 changes: 10 additions & 0 deletions packages/bpk-foundations-web/tokens/base.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@ export const privateSegmentedControlSurfaceContrastDay = "rgba(255, 255, 255, 0.
export const privateSegmentedControlSurfaceContrastNight = "rgb(19, 29, 43)";
export const privateSegmentedControlSurfaceContrastOnDay = "rgb(2, 77, 175)";
export const privateSegmentedControlSurfaceContrastOnNight = "rgb(5, 65, 132)";
export const privatePageIndicatorBtnBgCarouselTriggerDay = "rgba(255, 255, 255, 0.5)";
export const privatePageIndicatorBtnBgCarouselTriggerNight = "rgba(255, 255, 255, 0.5)";
export const privatePageIndicatorBtnBgHoverCarouselTriggerDay = "rgba(255, 255, 255, 0.8)";
export const privatePageIndicatorBtnBgHoverCarouselTriggerNight = "rgba(255, 255, 255, 0.8)";
export const colorSkyBlueShade03 = "rgb(2, 18, 44)";
export const colorPrimaryGradientLight = "rgb(0, 98, 227)";
export const colorErfoud = "rgb(255, 181, 77)";
Expand Down Expand Up @@ -746,6 +750,12 @@ export const overlayColors = {
overlayDay,
overlayNight,
};
export const pageIndicatorColors = {
privatePageIndicatorBtnBgCarouselTriggerDay,
privatePageIndicatorBtnBgCarouselTriggerNight,
privatePageIndicatorBtnBgHoverCarouselTriggerDay,
privatePageIndicatorBtnBgHoverCarouselTriggerNight,
};
export const panels = {
panelBorderColor,
};
Expand Down
28 changes: 28 additions & 0 deletions packages/bpk-foundations-web/tokens/base.raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,6 +1882,34 @@
"originalValue": "{!NIGHT_SKY}",
"name": "PRIVATE_SEGMENTED_CONTROL_SURFACE_CONTRAST_ON_NIGHT"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY": {
"type": "color",
"category": "page-indicator-colors",
"value": "rgba(255, 255, 255, 0.5)",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_DAY"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT": {
"type": "color",
"category": "page-indicator-colors",
"value": "rgba(255, 255, 255, 0.5)",
"originalValue": "{!WHITE_ALPHA_50}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_CAROUSEL_TRIGGER_NIGHT"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY": {
"type": "color",
"category": "page-indicator-colors",
"value": "rgba(255, 255, 255, 0.8)",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_DAY"
},
"PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT": {
"type": "color",
"category": "page-indicator-colors",
"value": "rgba(255, 255, 255, 0.8)",
"originalValue": "{!WHITE_ALPHA_80}",
"name": "PRIVATE_PAGE_INDICATOR_BTN_BG_HOVER_CAROUSEL_TRIGGER_NIGHT"
},
"COLOR_SKY_BLUE_SHADE_03": {
"value": "rgb(2, 18, 44)",
"deprecated": true,
Expand Down
8 changes: 8 additions & 0 deletions packages/bpk-foundations-web/tokens/base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,14 @@ $bpk-private-segmented-control-surface-contrast-night: rgb(19, 29, 43);
$bpk-private-segmented-control-surface-contrast-on-day: rgb(2, 77, 175);
/// @group segmented-control-colors
$bpk-private-segmented-control-surface-contrast-on-night: rgb(5, 65, 132);
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-carousel-trigger-day: rgba(255, 255, 255, 0.5);
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-carousel-trigger-night: rgba(255, 255, 255, 0.5);
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-hover-carousel-trigger-day: rgba(255, 255, 255, 0.8);
/// @group page-indicator-colors
$bpk-private-page-indicator-btn-bg-hover-carousel-trigger-night: rgba(255, 255, 255, 0.8);
/// @group colors
$bpk-color-sky-blue-shade-03: rgb(2, 18, 44);
/// @group colors
Expand Down
Loading