Support the battery capability in smoke/co subdriver #1978
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
nickolas-deboom
force-pushed
the
add-battery-to-smoke-co-alarm
branch
from
b1b669e to
35fac43
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against c596068 |
nickolas-deboom
force-pushed
the
add-battery-to-smoke-co-alarm
branch
from
35fac43 to
955f521
Compare
This change adds support for the battery percentage for devices that support the BatPercentRemaining attribute from the PowerSource cluster in addition to the battery level from the SmokeCoAlarm cluster.
nickolas-deboom
force-pushed
the
add-battery-to-smoke-co-alarm
branch
from
955f521 to
6f88987
Compare
|
Channel deleted. |
|
I'm curious, how does the device card look with this? To me, it seems like it would look confusing to have two different battery capabilities displayed without context. |
Use battery if supported by the device, otherwise use batteryLevel if the percentage is not supported.
nickolas-deboom
force-pushed
the
add-battery-to-smoke-co-alarm
branch
from
cf078cc to
a54538e
Compare
tpmanley
reviewed
Mar 11, 2025
ctowns
reviewed
Mar 12, 2025
|
should we close this PR with the introduction of #2045 |
|
Closing in favor of #2045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
This change adds support for the battery capability for devices that support the BatPercentRemaining attribute from the PowerSource cluster. If the attribute is not supported, use batteryLevel if supported, otherwise use a profile without a battery capability.
Summary of Completed Tests
Tested with the VDA Smoke/CO Alarm device as well as new unit tests.