Updating matter rvc ux #2343
Updating matter rvc ux #2343
Conversation
- Integrate components - Remove mode capability for run mode cluster Signed-off-by: HunsupJung <[email protected]>
Signed-off-by: HunsupJung <[email protected]>
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 69 files 449 suites 0s ⏱️ For more details on these errors, see this check. Results for commit a5a6c42. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a5a6c42 |
Signed-off-by: HunsupJung <[email protected]>
HunsupJung
force-pushed
the
feature/updating-matter-rvc-ux
branch
from
d1c20d1 to
df9744e
Compare
| @@ -5,6 +5,8 @@ components: | |||
| capabilities: | |||
| - id: robotCleanerOperatingState | |||
There was a problem hiding this comment.
Are these profiles currently in use by devices? If so, it might be better to create new profiles rather than removing capabilities to avoid breaking automations / rules for devices in the field.
There was a problem hiding this comment.
I confirmed these profiles are used by devices, and that automations are being used on the mode operation for at least a handful, though the percentage is small.
Instead of adding new profiles, I believe we should modify the system to use the benefits of modular profiles.
There was a problem hiding this comment.
@hcarter-775
Can we use the modular profiles by 9/9? If so, could you share the way to use the modular profiles?
| local function component_to_endpoint(device, component_name) | ||
| -- Use the find_default_endpoint function to return the first endpoint that | ||
| -- supports a given cluster. | ||
| return find_default_endpoint(device, clusters.RvcOperationalState.ID) |
There was a problem hiding this comment.
What does the endpoint structure typically look like for a RVC? Are the clusters usually all implemented on the same endpoint?
There was a problem hiding this comment.
I not sure, but Roborock implements Power Source, RVC Run Mode, RVC Clean Mode, RVC Operational State, and Service Area on the endpoint 1.
Signed-off-by: HunsupJung <[email protected]>
Type of Change
Checklist
Description of Change
The unnecessary mode capability for Run Mode cluster has been deleted.
Summary of Completed Tests
This feature is being tested with following TC in SVT.
https://smartthings.atlassian.net/wiki/spaces/STHK/pages/4088660856/REQ-22349+Matter+RVC+UX+Upgrade+TC