Skip to content

Updating matter rvc ux #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Updating matter rvc ux #2343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ceae111
Upgrade matter-rvc driver
HunsupJung Aug 15, 2025
355860d
Update Test Unit
HunsupJung Aug 15, 2025
df9744e
Fix failed part on luacheck
HunsupJung Aug 15, 2025
6cf2dfc
Re-match profile to support Service Area
HunsupJung Aug 24, 2025
9b377d5
Merge branch 'main' into feature/updating-matter-rvc-ux
HunsupJung Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 6 additions & 55 deletions drivers/SmartThings/matter-rvc/profiles/rvc-clean-mode-service-area.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ components:
capabilities:
- id: robotCleanerOperatingState
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these profiles currently in use by devices? If so, it might be better to create new profiles rather than removing capabilities to avoid breaking automations / rules for devices in the field.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed these profiles are used by devices, and that automations are being used on the mode operation for at least a handful, though the percentage is small.

Instead of adding new profiles, I believe we should modify the system to use the benefits of modular profiles.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hcarter-775
Can we use the modular profiles by 9/9? If so, could you share the way to use the modular profiles?

version: 1
- id: mode
version: 1
- id: serviceArea
version: 1
- id: refresh
Expand All @@ -13,20 +15,6 @@ components:
version: 1
categories:
- name: RobotCleaner
- id: runMode
label: Run mode
capabilities:
- id: mode
version: 1
categories:
- name: RobotCleaner
- id: cleanMode
label: Clean mode
capabilities:
- id: mode
version: 1
categories:
- name: RobotCleaner
deviceConfig:
dashboard:
states:
Expand All @@ -38,22 +26,15 @@ deviceConfig:
capability: robotCleanerOperatingState
version: 1
- component: main
capability: serviceArea
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/list/command/supportedValues
value: supportedArguments.value
- component: cleanMode
capability: mode
- component: main
capability: serviceArea
version: 1
patch:
- op: replace
path: /0/list/command/supportedValues
value: supportedArguments.value
- component: main
capability: refresh
version: 1
Expand All @@ -65,22 +46,7 @@ deviceConfig:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
value: mode.value
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
- component: cleanMode
- component: main
capability: mode
version: 1
patch:
Expand All @@ -99,22 +65,7 @@ deviceConfig:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
command: setMode
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
- component: cleanMode
- component: main
capability: mode
version: 1
patch:
Expand Down
59 changes: 5 additions & 54 deletions drivers/SmartThings/matter-rvc/profiles/rvc-clean-mode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,14 @@ components:
capabilities:
- id: robotCleanerOperatingState
version: 1
- id: mode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: RobotCleaner
- id: runMode
label: Run mode
capabilities:
- id: mode
version: 1
categories:
- name: RobotCleaner
- id: cleanMode
label: Clean mode
capabilities:
- id: mode
version: 1
categories:
- name: RobotCleaner
deviceConfig:
dashboard:
states:
Expand All @@ -35,14 +23,7 @@ deviceConfig:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/list/command/supportedValues
value: supportedArguments.value
- component: cleanMode
- component: main
capability: mode
version: 1
patch:
Expand All @@ -60,22 +41,7 @@ deviceConfig:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
value: mode.value
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
- component: cleanMode
- component: main
capability: mode
version: 1
patch:
Expand All @@ -94,22 +60,7 @@ deviceConfig:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
command: setMode
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
- component: cleanMode
- component: main
capability: mode
version: 1
patch:
Expand Down
72 changes: 0 additions & 72 deletions drivers/SmartThings/matter-rvc/profiles/rvc-service-area.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,75 +13,3 @@ components:
version: 1
categories:
- name: RobotCleaner
- id: runMode
label: Run mode
capabilities:
- id: mode
version: 1
categories:
- name: RobotCleaner
deviceConfig:
dashboard:
states:
- component: main
capability: robotCleanerOperatingState
version: 1
detailView:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: main
capability: serviceArea
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/list/command/supportedValues
value: supportedArguments.value
- component: main
capability: refresh
version: 1
- component: main
capability: firmwareUpdate
version: 1
automation:
conditions:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
value: mode.value
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
actions:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
command: setMode
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
69 changes: 0 additions & 69 deletions drivers/SmartThings/matter-rvc/profiles/rvc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,72 +11,3 @@ components:
version: 1
categories:
- name: RobotCleaner
- id: runMode
label: Run mode
capabilities:
- id: mode
version: 1
categories:
- name: RobotCleaner
deviceConfig:
dashboard:
states:
- component: main
capability: robotCleanerOperatingState
version: 1
detailView:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/list/command/supportedValues
value: supportedArguments.value
- component: main
capability: refresh
version: 1
- component: main
capability: firmwareUpdate
version: 1
automation:
conditions:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
value: mode.value
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
actions:
- component: main
capability: robotCleanerOperatingState
version: 1
- component: runMode
capability: mode
version: 1
patch:
- op: replace
path: /0/displayType
value: dynamicList
- op: add
path: /0/dynamicList
value:
command: setMode
supportedValues:
value: supportedModes.value
- op: remove
path: /0/list
Loading
Loading