Miscellaneous tweaking to the C code #857
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factors out several sub-functions for greater clarity, and changes bubble sort to (usually faster) insertion sort.
Includes not using raw addresses in places where we actually know the type properly (e.g., for the fixed region metadata of a synaptic row)
... use of a random number source per selected random partner. Note that this works because the original selected neuron ID just needs to be converted into a subpop/local ID pair. We simply don't need to draw another random number to achieve the choice of the second part; there was already sufficient random information in the first random number to provide an adequate selection. We just need to stop throwing the information away!
dkfellows
added
enhancement
minor
There can be only one...
It shouldn't change any real behaviour: the compiler can infer that the pointer is non-NULL in all cases. Documenting that we do this is a good plan anyway.
Open
dkfellows
added a commit
that referenced
this pull request
Nov 16, 2020
Complicated because rows have multiple VLAs within them. Code recovered from #857 which was becoming too unwieldy to keep up to date.
This was referenced Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.