Fix a race condition in WebLocksLeader where transactions could be replayed twice on page load #1046
+137
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 350d887 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 89.4 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.35 kB ℹ️ View Unchanged
|
KyleAMathews
force-pushed
the
claude/investigate-discord-bug-TD4bH
branch
3 times, most recently
from
4171209 to
414db19
Compare
…nitialization Fix a race condition in WebLocksLeader where transactions could be replayed twice on page load. The issue occurred because: 1. requestLeadership() returned true immediately when lock was available 2. But notifyLeadershipChange(true) was called asynchronously when the fire-and-forget navigator.locks.request() actually acquired the lock 3. This caused loadAndReplayTransactions() to be called twice - once manually and once via the callback The fix has two parts: 1. Set WebLocksLeader.isLeaderState = true synchronously when we know the lock is available, so the async notifyLeadershipChange(true) doesn't trigger the callback again 2. Set OfflineExecutor.isLeaderState based on requestLeadership() return value, since we can no longer rely on the callback to set it Reported by Toba on Discord.
KyleAMathews
force-pushed
the
claude/investigate-discord-bug-TD4bH
branch
from
414db19 to
350d887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition in WebLocksLeader where transactions could be replayed twice on page load. The issue occurred because:
The fix sets isLeaderState = true synchronously when we know the lock is available, so the async notifyLeadershipChange(true) doesn't trigger the callback again (the guard checks isLeaderState !== isLeader).
Reported by Toba on Discord.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact