Skip to content

Conversation

m2na7
Copy link

@m2na7 m2na7 commented Aug 28, 2025

Description

Fixes issue where isDefaultValue was not updating correctly when changing date fields.

Problem

The evaluate function was treating Date objects as regular objects, causing incorrect equality comparisons for date values.

Solution

  • Added specific Date object comparison using getTime() method
  • Added comprehensive tests for Date object comparison scenarios

Fixes

Closes #1712

Copy link

nx-cloud bot commented Aug 30, 2025

View your CI Pipeline Execution ↗ for commit c010d5d

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 1s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-30 11:01:55 UTC

Copy link

pkg-pr-new bot commented Aug 30, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1717

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1717

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1717

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1717

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1717

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1717

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1717

commit: c010d5d

Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.53%. Comparing base (24e30ab) to head (c010d5d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
+ Coverage   90.52%   90.53%   +0.01%     
==========================================
  Files          37       37              
  Lines        1688     1690       +2     
  Branches      421      422       +1     
==========================================
+ Hits         1528     1530       +2     
  Misses        143      143              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isDefaultValue not updating when changing date field
1 participant