Skip to content

fix(form-core): Date comparison in evaluate function for isDefaultValue #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(form-core): Date comparison in evaluate function for isDefaultValue #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1bda2d
fix(form-core): add support for Date object comparison
m2na7 Aug 28, 2025
cc5bfa9
test(form-core): add tests for Date object comparison
m2na7 Aug 28, 2025
c010d5d
refactor(form-core): remove unnecessary blank line in utils.ts
m2na7 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/form-core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,10 @@ export function evaluate<T>(objA: T, objB: T) {
return false
}

if (objA instanceof Date && objB instanceof Date) {
return objA.getTime() === objB.getTime()
}

if (objA instanceof Map && objB instanceof Map) {
if (objA.size !== objB.size) return false
for (const [k, v] of objA) {
Expand Down
18 changes: 18 additions & 0 deletions packages/form-core/tests/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,24 @@ describe('evaluate', () => {
)
expect(objComplexTrue).toEqual(true)
})

it('should test equality between Date objects', () => {
const date1 = new Date('2025-01-01T00:00:00.000Z')
const date2 = new Date('2025-01-01T00:00:00.000Z')
const date3 = new Date('2025-01-02T00:00:00.000Z')

const dateTrue = evaluate(date1, date2)
expect(dateTrue).toEqual(true)

const dateFalse = evaluate(date1, date3)
expect(dateFalse).toEqual(false)

const dateObjectTrue = evaluate({ date: date1 }, { date: date2 })
expect(dateObjectTrue).toEqual(true)

const dateObjectFalse = evaluate({ date: date1 }, { date: date3 })
expect(dateObjectFalse).toEqual(false)
})
})

describe('concatenatePaths', () => {
Expand Down
Loading