Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type definition by removing Partial #148

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix type definition by removing Partial #148

wants to merge 3 commits into from

Conversation

teppeis
Copy link
Contributor

@teppeis teppeis commented May 28, 2019 •
edited
Loading

fixes #147

Also overloading is removed because deepmerge<T1, T2>(x: T1, y: T2): T1 & T2 includes deepmerge<T>(x: T, y: T): T.

@teppeis
Copy link
Contributor Author

teppeis commented May 29, 2019

I've updated for #147 (comment).

@RebeccaStevens RebeccaStevens mentioned this pull request Nov 5, 2020
Open
@RebeccaStevens RebeccaStevens mentioned this pull request Nov 17, 2020
Closed
@TehShrike TehShrike added the ts Typescript-related label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ts Typescript-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Useless Partial in type definition
2 participants
@teppeis @TehShrike