Made transitions between lyrics smoother#977
Open
mitzCanCode wants to merge 1 commit intoTheBoredTeam:devfrom
Open
Made transitions between lyrics smoother#977mitzCanCode wants to merge 1 commit intoTheBoredTeam:devfrom
mitzCanCode wants to merge 1 commit intoTheBoredTeam:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While using the app, I noticed that the lyric animations were snapping instead of transitioning smoothly. This led me to realize that the transition was not being triggered correctly.
Changes
.id()modifier to each lyric line so the transition can be properly triggered.Notes / Future Work
A possible future improvement would be to reintroduce the marquee text with a controlled timing system. If the marquee speed is synced to the lyric duration, it could reset its position cleanly and avoid causing
GeometryReaderlayout glitches.Screen.Recording.2026-01-14.at.6.36.14.PM.mov