Skip to content

Made transitions between lyrics smoother #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mitzCanCode wants to merge 1 commit into
base: dev
Choose a base branch
from
+12 −12
Open

Made transitions between lyrics smoother #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions boringNotch/components/Notch/NotchHomeView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// boringNotch
//
// Created by Hugo Persson on 2024-08-18.
// Modified by Harsh Vardhan Goswami & Richard Kunkli & Mustafa Ramadan
// Modified by Harsh Vardhan Goswami & Richard Kunkli & Mustafa Ramadan & Dimitris Chatzigeorgiou
//

import Combine
Expand Down Expand Up @@ -173,17 +173,17 @@ struct MusicControlsView: View {
let v = scalar.value
return v >= 0x0600 && v <= 0x06FF
}
MarqueeText(
.constant(line),
font: .subheadline,
nsFont: .subheadline,
textColor: musicManager.isFetchingLyrics ? .gray.opacity(0.7) : .gray,
frameWidth: width
)
.font(isPersian ? .custom("Vazirmatn-Regular", size: NSFont.preferredFont(forTextStyle: .subheadline).pointSize) : .subheadline)
.lineLimit(1)
.opacity(musicManager.isPlaying ? 1 : 0)
.transition(.opacity.combined(with: .move(edge: .top)))
Text(line)
.font(isPersian ? .custom("Vazirmatn-Regular", size: NSFont.preferredFont(forTextStyle: .subheadline).pointSize) : .subheadline)
.lineLimit(1)
.opacity(musicManager.isPlaying ? 1 : 0)
.transition(.asymmetric(
insertion: .opacity.combined(with: .move(edge: .bottom)),
removal: .opacity.combined(with: .move(edge: .top))
))
.id(line)
.animation(.easeInOut(duration: 0.5), value: line)
}
}
}
Expand Down