-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Object Basics: Move array content to "Arrays and Loops" lesson #29521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Object Basics: Move array content to "Arrays and Loops" lesson #29521
Conversation
Added link to MDN array docs for referencing. Restructured main contents Array section bullets for a slightly more logical order.
Follows lesson style guide for heading case Hyphenated as "test-driven" is an adjective. This does not affect the ID fragment used for the KC question link.
Single line breaks do not render any differently. Paragraphs should be contained in their own lines and separated by a single blank line. Small verbiage amendments to map/filter explanations to move language away from "mastering" and "shorter means better".
Opinion wanted: With the array method contents now in the Arrays and Loops lesson, I feel like the section order (Arrays -> Loops -> Array method stuff) could flow better if Loops came first, followed by Arrays then the Array method stuff. The array resources either mention loops or otherwise use looping concepts when demonstrating array methods. Meanwhile, the MDN loops resource (not the other one) only very briefly mention arrays, and not in an array method context, only to use a for..of loop for. I feel like going Loops first would make more sense, perhaps with a tiny note that arrays are just lists of things and we'll cover them in the next section. Feels better than going Arrays and methods first, which naturally include iteration, then introducing loops like they're completely separate. If agreed, I can open a separate issue for this after this one is complete, and it might mean the lesson could do with renaming to "Loops and Arrays" (which would require a file name change, a link change in Object Basics (only place it's linked), and a change in the website repo for the title). |
As per TheOdinProject#29500 (comment) Not particularly relevant to the lesson (being an object alone isn't sufficient) and rest params are recommended instead for its purpose anyway.
Some exercises use arrays of objects - not appropriate to assign until the Object Basics lesson.
11df869
to
8f68735
Compare
Was improved in TheOdinProject#29595 but was destroyed in the preceding merge commit.
Because
The lesson contents on array methods in Object Basics is misplaced and would be better served in the Arrays and Loops lesson instead. This will keep both lessons more focused on relevant topics.
This PR
Issue
Closes #29500
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section