Tweaks #46
Tweaks #46
Conversation
| return commands.listCommands(); | ||
| } | ||
| }; | ||
|
|
||
| const endpoint = windowEndpoint(self.parent); | ||
| expose(api, endpoint); | ||
|
|
||
| app.started.then(() => { | ||
| window.parent?.postMessage('extension-loaded', '*'); |
There was a problem hiding this comment.
Wondering if createBridge could expose a new ready: Promise<void>, to make waiting for the extension in the IFrame to be ready more convenient?
There was a problem hiding this comment.
Also there may be some race conditions depending on when the host defines the event listener and when the IFrame posts the message (too early / late).
There was a problem hiding this comment.
Looks like there is an open issue about that in Comlink: GoogleChromeLabs/comlink#665
So in our case we can likely implement a workaround by defining custom logic for exposing the ready state of the IFrame.
There was a problem hiding this comment.
Opened #47 against this PR to explore adding a ready promise.
|
please update snapshots |
|
please update snapshots |
|
please update snapshots |
This updates the
listCommandsinterface to return a promise and sends a message to the host indicating the extension has loaded.