Skip to content

Add a ready promise #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

Add a ready promise #47

merged 4 commits into from
May 14, 2025

Conversation

jtpio
Copy link
Collaborator

@jtpio jtpio commented Apr 29, 2025

Building on top of #46.

@jtpio jtpio mentioned this pull request Apr 29, 2025
@jtpio jtpio added the enhancement New feature or request label Apr 29, 2025
@jtpio jtpio changed the title Ready promise Add a ready promise Apr 29, 2025
@jtpio jtpio marked this pull request as ready for review May 14, 2025 13:21
@gjmooney gjmooney merged commit 20b7c53 into TileDB-Inc:tweaks May 14, 2025
7 of 8 checks passed
@jtpio jtpio deleted the ready-promise branch May 14, 2025 13:33
jtpio added a commit that referenced this pull request May 20, 2025
* Change listCommands return to a promise

* Send message when ready

* Enable returns from execute

* Add a `ready` promise (#47)

* ready promise

* custom proxy

* update demo

* lint

* Update Playwright Snapshots

* Save video

* Update snapshot names

* lint

* Add structuredClone check

* Change viewport size for tests

* Update tests

---------

Co-authored-by: Greg <[email protected]>
Co-authored-by: Jeremy Tuloup <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants