-
Notifications
You must be signed in to change notification settings - Fork 24
Photons histEFT #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bryates
wants to merge
201
commits into
master
Choose a base branch
from
photons_histEFT
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Photons histEFT #421
Changes from 1 commit
Commits
Show all changes
201 commits
Select commit
Hold shift + click to select a range
231a5f8
Basic photon selection
bryates 94ba9ca
Saving single photon pT
bryates 3a74343
edited photon selection category to include kinematic cuts
abasnet97 fb442bb
edited 2los CR category
abasnet97 f704e98
modified photon selection furthermore
abasnet97 58d2662
Merge all recent master changes to photon branch
abasnet97 0837563
changed photon ID from tight to medium for now
abasnet97 c594dfe
More flake8 fixes
kmohrman 2ec1020
More flake8 fixes..
kmohrman 439e92f
Basic photon selection
bryates d0748bc
Saving single photon pT
bryates 58c9f63
Adding ttgamma selection
bryates cc6fcc9
more photon selection edits
abasnet97 2f5cc8c
Add cutBased hist, medium photon ID
bryates ff5b88c
Merge branch 'photons' of github.com:TopEFT/topcoffea into photons
bryates ed17052
Relaxed veto
bryates 44b5fe1
Fixed typo
bryates 7f55206
editing the processor to include relaxed cutBasedID for photon
abasnet97 18f210d
fixing typo in selection.py
abasnet97 cb0a510
Working version
bryates 9511813
fix masks
bryates 1855fb3
merged changes from master after topcoffea refactoring
abasnet97 e38731b
added new files related to photon gen processor
abasnet97 4c02a90
new edits to gen level processor
abasnet97 178aec4
modify genlepflav mask
abasnet97 573ae6c
several modifications to photon object and event selections
abasnet97 eda50d7
implemented ttgamma ttbar overlap removal
abasnet97 f80b263
added genParentage
abasnet97 0117164
major changes to overlap removal implementation and other cleanups
abasnet97 54085ea
added a helper script to make njet-nbjet histogram
abasnet97 d754dec
added a helper function to make jet_bjet plot
abasnet97 7c7e73d
updated processor file to include new control regions for ttgamma work
abasnet97 3911341
updated event and object selection to include CR selections for ttgam…
abasnet97 19d051e
removing ttgamma and Zgamma from conversion samples list
abasnet97 98f5df9
Adding photon SFs and systematic
bryates e2ced76
Use `photonSFs` branch of topcoffea
bryates 7a705e6
Fix some lint issues
bryates 5a17f4d
Remove stray print
bryates e9c4c78
Removing unused masks
bryates 285aef2
TTGamma is now a signal process, TTG->ttA
bryates bf52a61
Pull latest datacard maker, update categories
bryates 98bfa02
Zero our missing sumw2
bryates 86113a4
Merge branch 'master' into photons_rebase
bryates 4003f38
Fix lint, move gen processor to histEFT
bryates d5a61ea
More lint
bryates 1b18c4b
Yet more lint
bryates 2485b1a
Fix typos
bryates 695e231
Lint again!
bryates 501a834
Never-ending lint
bryates 22ef77b
Add `ttA` to processes
bryates 77a8ea7
Processor runs now
bryates 1f2a507
Merge branch 'photons_histEFT' into photon_dc
bryates fb66108
Use new `EGamma_SF2D_err` hists
bryates 047aad7
Load photon SFs, still load lepton SFs in those channels
bryates c33e8c6
Simplify 2l category
bryates ccae998
Back to main TopCoffea branch
bryates ba4b98f
Fix some comment typos
bryates 5aa2036
Fix typo in 2l
bryates 780e38c
Back to main TopCoffea branch
bryates 380d4f3
Replace prune with slice
bryates da40fc5
Fixed CI yields, removed (hopefully) unneeded code
bryates b85714b
Merge branch 'photons_histEFT' into photon_dc
bryates b5aa458
Update photon SR
bryates c42728c
Clean up run script
bryates fb4a267
Better 2l cats
bryates 6015877
Switch to medium SFs
bryates 018157b
Restored missing overlap functions
bryates 519ff51
Checkout `photon_seedveto` on TopCoffea
bryates 8491d25
Fix lint
bryates ef20b9a
Working pxiel seed veto and CSEV
bryates b826e72
Fix lint space at end
bryates beafecf
Fix lint indents
bryates 31225ac
Merge branch 'master' into photons_histEFT
bryates 1832dfa
Add photon categories
bryates 24536db
Added ttgamma categories to ref json
bryates 84edb0b
Update main.yml
bryates ee7a0db
Fix typo in photon error propagation
bryates 84c2cb0
Yields after applying new photon vetoes (pixel and CSEV)
bryates 72e0e0e
Yields after TopCoffea correction-lib updates
bryates 30b3af4
Merge branch 'master' into photons_histEFT_rebase
bryates 4c77311
Small changes for photon channels
bryates 7415ccb
Merge branch 'photons_histEFT' into photon_dc
bryates 9ae1951
Merge branch 'photons_histEFT' into photon_dc
bryates fb6238d
"Fix" for 2los photon channels
bryates 30eacf4
Add `TTGamma_private`
bryates 14ceef4
Skip `renormfact` since we never used it
bryates bca3988
Merge branch 'master' into photons_histEFT
bryates b1e716a
adding a new plotting helper script. will add the changes to analysis…
abasnet97 adabbab
lint fix
abasnet97 c2089dc
Some TTGamma files missing
bryates fc9e8f2
Merge branch 'photons_histEFT' into photon_dc
bryates 2d64ee8
Latest IM changes
bryates 61b479f
wc ranges from master
bryates febd140
Fixed ttA typo
bryates ce27be4
added new histograms relevant to non-prompt photon estimation
abasnet97 4d17ed9
Merge branch 'photons_histEFT' of https://github.com/TopEFT/topeft in…
abasnet97 0efd8cb
adding prompt subtraction samples for photons
abasnet97 90157cf
a new helper function to aid histogram filling
abasnet97 03c0e8f
updated corrections, event and object selection scripts to handle non…
abasnet97 56448ea
adding numpy files for photon FR and kMC
abasnet97 a625eff
lint fixes
abasnet97 90d52da
more lint fixes cause why not
abasnet97 e524a53
temporarily comment out photon_pt_eta hist
abasnet97 d1294ea
massive overhaul of photon selection and analysis channels
abasnet97 8e16511
clean the processor and add nonprompt fakerate as event weight
abasnet97 630d4a2
added photon fakerate and kMC numpy files
abasnet97 b1ec71d
adding ISR/FSR split of photons in ZGamma sample
abasnet97 07b0530
fix lint
abasnet97 ddad937
bringing photon_pt_eta histogram back
abasnet97 8d481f8
added modifications to perform nonprompt estimation of photons
abasnet97 56cb888
lint fixes
abasnet97 f866b86
possible attempt at fixing CI
abasnet97 b04ddb3
new photon FRs and kMC factors after including EFT signal samples
abasnet97 117c382
editing processor to handle eft weights for 2D histogram
abasnet97 eb6520a
further edits to the nonprompt mc stat uncertainty propagation
abasnet97 5e0ea7c
lint fixes
abasnet97 3ec217e
Merge pull request #420 from TopEFT/photon_dc
abasnet97 fb42fc1
adding EFT sig samples in prompt photon subtraction list
abasnet97 135f3a0
Merge branch 'photons_histEFT' of https://github.com/TopEFT/topeft in…
abasnet97 1f5554d
modifications to datacard_tools for photon channels
abasnet97 51e2829
Merging master
bryates 258fab5
Missing calls
bryates 81a4e4d
Merge branch 'master' into photons_histEFT_master2
bryates 4f93da2
Indent
bryates 3c9f638
Turn off debug messages
bryates 8f3a250
Photon systs only when flag is set
bryates 4006c45
Fix typo
bryates 9caecd2
Should all work
bryates 60213b9
Photon channels
bryates 3882dd4
Fixed processor
bryates 6424d8b
Removed comment
bryates 641247e
Lint
bryates 80d5187
Undo change
bryates 9c78263
Remove 2los_ph from cat lst
bryates 7c116b3
Fix CR name
bryates 3276a6e
Add 0m b mask for CR
bryates d4c27ce
Add sf and of
bryates 83eb2e2
More channel updates
bryates a23f37e
Fixed flavor channels
bryates f9faf23
modified appl axes names and channel list json
abasnet97 6658b39
some minor modifications to datacard tools
abasnet97 2991ffe
adding ST TWG sample to non prompt photon subtraction list
abasnet97 4696058
adding 1jet diboson uncertainty (temporary fix to make ttA datacards)
abasnet97 c89284a
lint fixes
abasnet97 f37da9b
adding jsons for UL17 and UL16APV ttgamma EFT samples and modifying c…
abasnet97 369552b
adding photon mask on ch_lst_test json
abasnet97 7724993
including photon relevant code block inside the ttA_analysis flag
abasnet97 444baaa
bit more restructuring of the analysis processor
abasnet97 828e76e
remove photon_pt_eta 2D hist once they serve their purpose
abasnet97 be8bb08
lint fixes
abasnet97 7018870
added nEvents and nGenEvents info to ttgamma jsons
abasnet97 914c216
added new jsons and cfg file for TWGToLL samples
abasnet97 5ca5a3a
edited ttgamma channels in channel list json
abasnet97 e200e74
modified corrections module to add correction factor for private ttga…
abasnet97 1afe914
update new photon FR and kMC npz files and ttgamma correction factor …
abasnet97 f14b8e7
remove hardcoded bin edges
abasnet97 b0af705
minor edits to params and rate_systs json files
abasnet97 043a5f9
several changes to analysis processor to include private ttgamma corr…
abasnet97 4a9d8f0
changing some aspects of nonprompt photon estimation and modification…
abasnet97 c67a3d0
lint fixes
abasnet97 9cfa06c
appeased the lint god
abasnet97 3b98556
cleaning overlap removal block
abasnet97 fd72623
modifying some photon kinematic variables binning
abasnet97 afb8941
changing some kinematic variable binning
abasnet97 57e573d
modified private ttA CF block to handle systematic uncertainty
abasnet97 b325ab1
few more changes on non prompt photon estimation block
abasnet97 bef0b0c
modifying photon fakerates and kmc factors paths
abasnet97 addb7d7
use validation test instead of closure test
abasnet97 2b15f21
minor edits to kinematic binnings
abasnet97 b410979
changing some kinematic variable binning
abasnet97 476ccf6
modified private ttA CF block to handle systematic uncertainty
abasnet97 955b7ec
few more changes on non prompt photon estimation block
abasnet97 a834944
modifying photon fakerates and kmc factors paths
abasnet97 81a12d4
use validation test instead of closure test
abasnet97 81ca2ef
minor edits to kinematic binnings
abasnet97 216b478
Merge branch 'photons_histEFT' of github.com:TopEFT/topeft into photo…
abasnet97 2271e93
removed harcoded kinematic cuts
abasnet97 8f4ab95
adding pdf and qcd scale uncertainties on ttg NLO xsec
abasnet97 2fe2ac0
fix a typo
abasnet97 53d6f70
modify nonprompt photon syst unc on last photon pt bin
abasnet97 ce395d2
delete redundant fakerate files
abasnet97 1da4d6d
adding new syst. uncertainties relevant to ttA analyses
abasnet97 366b58e
adding tW and tbarW samples in overlap removal list
abasnet97 80d778d
adding ttg correction systematic uncertainties
abasnet97 1f90e83
documenting photon fakerate derivation steps
abasnet97 e2003f8
editing the README
abasnet97 7b9f16c
more edits
abasnet97 c5731c7
new photon fakerates after fixing tW/tWgamma overlap removal
abasnet97 df79351
ttgamma EFT samples for Run2
abasnet97 6a6d669
adding data mc agreement CR back
abasnet97 ec1a474
missing parton root file for ttA channels
abasnet97 74c55e1
modifying prompt subtraction sample list
abasnet97 48e64d4
correct overlap removal sample list
abasnet97 8d7b8ca
updating nonprompt unc propagation helper instruction
abasnet97 877f667
adding option to pass flag to run ttA setup for datacard making
abasnet97 7fb1b33
update unskimmed ttg sample jsons
abasnet97 65f6bc5
edited setup.py to include photon fakerates, kmc, and ttg correction …
abasnet97 032d161
scripts to derive nonprompt photon fakerates and kmc factors
abasnet97 f236d0e
lint fixes
abasnet97 7e189c3
more lint fixes
abasnet97 8d2e5d4
why cant lint fix itself?
abasnet97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
input_samples/sample_jsons/signal_samples/private_UL/UL16APV_ttgamma_dilept_NDSkim.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22,456 changes: 22,456 additions & 0 deletions
22,456
input_samples/sample_jsons/signal_samples/private_UL/UL16_ttgamma_dilept_b1.json
Large diffs are not rendered by default.
Oops, something went wrong.
76 changes: 76 additions & 0 deletions
76
input_samples/sample_jsons/signal_samples/private_UL/UL16_ttgamma_dilept_b1_NDSkim.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| { | ||
| "xsec": 2.9922, | ||
| "year": "2016", | ||
| "treeName": "Events", | ||
| "histAxisName": "TTGamma_Dilept_privateUL16", | ||
| "options": "", | ||
| "WCnames": [ | ||
| "cQq11", | ||
| "ctq8", | ||
| "ctG", | ||
| "ctW", | ||
| "cpt", | ||
| "ctq1", | ||
| "cpQM", | ||
| "cQq83", | ||
| "cQq81", | ||
| "cQq13", | ||
| "ctZ" | ||
| ], | ||
| "files": [ | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_22580.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_18331.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_21827.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_2378.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_9979.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_8713.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_4840.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_5313.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_15265.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_13898.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_7555.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_19062.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_12238.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_4013.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_20442.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_22521.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_1516.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_8264.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_10827.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_16514.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_3326.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_21285.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_4463.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_12788.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_10309.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_11335.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_14635.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_6334.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_11786.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_2749.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_6872.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_15909.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_13249.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_19795.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_9358.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_5781.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_17722.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_22615.root", | ||
| "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304/output_17020.root" | ||
| ], | ||
| "nEvents": 1, | ||
| "nGenEvents": 1, | ||
| "nSumOfWeights": 118223.8147469468, | ||
| "isData": false, | ||
| "path": "/store/user/abasnet/skims/mc/new-lepMVA/private_UL/UL2016/FullR2/ttgamma_private_b1/v250304", | ||
| "nSumOfWeights_ISRUp": 122926.48812754746, | ||
| "nSumOfWeights_ISRDown": 112623.2370736131, | ||
| "nSumOfWeights_FSRUp": 118181.05974823498, | ||
| "nSumOfWeights_FSRDown": 117943.18635179116, | ||
| "nSumOfWeights_renormUp": 98329.91161869855, | ||
| "nSumOfWeights_renormDown": 145018.04456489964, | ||
| "nSumOfWeights_factUp": 112500.21162745025, | ||
| "nSumOfWeights_factDown": 124523.57104116865, | ||
| "nSumOfWeights_renormfactUp": 93570.12184427769, | ||
| "nSumOfWeights_renormfactDown": 152742.7348497723 | ||
| } |
2 changes: 1 addition & 1 deletion
2
input_samples/sample_jsons/signal_samples/private_UL/UL17_ttgamma_dilept_NDSkim.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was this change to the xsec? Was that the 33% correction? If so, we should consider moving that somewhere else instead of overwriting the xsec, just to make it more clear for future users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Do you suggest moving that info directly inside the analysis processor where if ttgamma sample is being used, we scale the xsec by 1.33? In any case, neither of the approach should be permanent anyway cause like Kevin said, scaling cross-section won't be a physically correct thing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be best to store that factor somewhere in a json/yml file.