Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master<-dev #1018

Merged
merged 44 commits into from
Sep 19, 2024
Merged

master<-dev #1018

merged 44 commits into from
Sep 19, 2024

Conversation

TinyKitten
Copy link
Member

ほとんどデータ更新

mittan12 and others added 27 commits September 18, 2024 15:53
JR列車名追加
京王線 小田急線 系統追加
通勤快急追加
特快速追加
簡易的な種別データ整合性チェック
Update 5!station_station_types.csv
京阪 神戸電鉄系統追加
支線種別名修正
@TinyKitten TinyKitten self-assigned this Sep 19, 2024
@github-actions github-actions bot added the ci/cd label Sep 19, 2024
pushじゃなくてプルリクでデータ検証してほしい
@@ -1674,8 +1674,16 @@ station_cd,station_g_cd,station_name,station_name_k,station_name_r,station_name_
1131201,1130101,東京,トウキョウ,Tōkyō,東京,도쿄,01,,,TYO,11312,13,100-0005,東京都千代田区丸の内一丁目,139.766103,35.681391,0000-00-00,0000-00-00,0,1131201
1131202,1130223,神田,カンダ,Kanda,神田,간다,02,,,KND,11312,13,101-0044,東京都千代田区鍛冶町二丁目13-1,139.770641,35.691173,0000-00-00,0000-00-00,0,1131202
1131203,1131203,御茶ノ水,オチャノミズ,Ochanomizu,御茶之水,오차노미즈,03,,,,11312,13,101-0062,東京都千代田区神田駿河台2丁目,139.764955,35.699605,0000-00-00,0000-00-00,0,1131203
1131204,1131204,水道橋,スイドウバシ,Suidōbashi,水道桥,스이도바시,17,,,,11313,13,101-0061,東京都千代田区三崎町2丁目,139.754312,35.702039,0000-00-00,0000-00-00,0,1131204
Copy link
Member Author

@TinyKitten TinyKitten Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ソート番号とか駅IDとか不整合起こしてるので追加してくれた人には申し訳ないけど今回のmasterへのマージ時にこのファイルの全ての変更を無効化もしくは削除しないといけない

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1020
一旦全部巻き戻した

This comment was marked as outdated.

中央線データ追加および修正
@TinyKitten
Copy link
Member Author

stationsの変更ですが中央線快速の通過する各駅を追加したデータを公開するには通過種別を自動選択させる必要がある認識ですが、そもそも快速の自動選択が今バグってそうなのでstationsの変更だけリリース延期させてください

@TinyKitten TinyKitten mentioned this pull request Sep 19, 2024
@TinyKitten
Copy link
Member Author

#1027
いったんこっちでリリース

@TinyKitten TinyKitten merged commit 12a93d8 into master Sep 19, 2024
11 checks passed
This was referenced Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants