feat(sdk-core): Add Base Sepolia constants #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the Chain ID, Addresses, and WETH token configuration for the Base Sepolia network (84532). This uses the addresses referenced in the Base Deployments doc: https://docs.uniswap.org/contracts/v3/reference/deployments/base-deployments This also uses this as the source for the WETH token on base sepolia: https://sepolia.basescan.org/token/0x4200000000000000000000000000000000000006 This is following up on the changes that were being made on the old SDK repos: Uniswap/sdk-core#110 Uniswap/smart-order-router#494
alex-stone
added a commit
to alex-stone/smart-order-router
that referenced
this pull request
Nov 5, 2024
This bumps the `sdk-core` to pull in configuration changes made in: Uniswap/sdks#192 This will be replaced by a standard version bump once that PR lands properly.
Member
|
looks like github CI has to run from the Uniswap/sdks repo, not a forked repo. I created a PR to expedite supporting Base Sepolia #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the Chain ID, Addresses, and WETH token configuration for the Base Sepolia network (84532).
This uses the addresses referenced in the Base Deployments doc: https://docs.uniswap.org/contracts/v3/reference/deployments/base-deployments
This also uses this as the source for the WETH token on base sepolia: https://sepolia.basescan.org/token/0x4200000000000000000000000000000000000006
This is following up on the changes that were being made on the old SDK repos:
Uniswap/sdk-core#110
Uniswap/smart-order-router#494
How Has This Been Tested?
This has not been explicitly tested yet (outside of CI), will be utilizing this in the context of Uniswap/smart-order-router.
Are there any breaking changes?
This should be purely additive constant configurations.
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]
Plan to extend this to smart-order-router similar to: Uniswap/smart-order-router#494