Skip to content

Clean-room system menu administration #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mambax7 merged 58 commits into from
Mar 20, 2026

Close open dropdowns on outside tap

8319aee
Select commit
Loading
Failed to load commit list.
Merged

Clean-room system menu administration #1666

Close open dropdowns on outside tap
8319aee
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 20, 2026 in 48s

Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 852 in htdocs/themes/xbootstrap5/style.css

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Text does not meet the minimal contrast requirement with its background. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0IW-qe2KxiX-UOYpUB&open=AZ0IW-qe2KxiX-UOYpUB&pullRequest=1666

Check warning on line 169 in htdocs/modules/system/js/menus.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MoqJsw9t8RWl20q&open=AZ0G_MoqJsw9t8RWl20q&pullRequest=1666

Check failure on line 54 in htdocs/modules/system/js/multilevelmenu.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MqLJsw9t8RWl20y&open=AZ0G_MqLJsw9t8RWl20y&pullRequest=1666

Check failure on line 85 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ERROR_ITEMDEPTH" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21x&open=AZ0G_MrxJsw9t8RWl21x&pullRequest=1666

Check failure on line 93 in htdocs/modules/system/language/english/modinfo.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_MI_SYSTEM_MENUS_ACTIVE_DESC" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MscJsw9t8RWl212&open=AZ0G_MscJsw9t8RWl212&pullRequest=1666

Check failure on line 16 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_NAV_BACK" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21D&open=AZ0G_MrxJsw9t8RWl21D&pullRequest=1666

Check failure on line 24 in htdocs/modules/system/js/multilevelmenu.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MqLJsw9t8RWl20v&open=AZ0G_MqLJsw9t8RWl20v&pullRequest=1666

Check warning on line 164 in htdocs/modules/system/admin/menus/main.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0HgomB5uVuQHfQ08zz&open=AZ0HgomB5uVuQHfQ08zz&pullRequest=1666

Check failure on line 63 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ITEMPARENT" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21h&open=AZ0G_MrxJsw9t8RWl21h&pullRequest=1666

Check failure on line 89 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ERROR_ITEMDISABLE" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl210&open=AZ0G_MrxJsw9t8RWl210&pullRequest=1666

Check failure on line 57 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ITEMPREFIX_DESC" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21b&open=AZ0G_MrxJsw9t8RWl21b&pullRequest=1666

Check warning on line 188 in htdocs/modules/system/include/update.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "system_menu_drop_parent_foreign_keys" to match the regular expression ^[a-z][a-zA-Z0-9]*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MtnJsw9t8RWl215&open=AZ0G_MtnJsw9t8RWl215&pullRequest=1666

Check failure on line 74 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_PERMISSION_VIEW_ITEM" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21o&open=AZ0G_MrxJsw9t8RWl21o&pullRequest=1666

Check failure on line 170 in htdocs/modules/system/js/menus.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MoqJsw9t8RWl20r&open=AZ0G_MoqJsw9t8RWl20r&pullRequest=1666

Check failure on line 43 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_CATSUFFIX_DESC" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21P&open=AZ0G_MrxJsw9t8RWl21P&pullRequest=1666

Check failure on line 82 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ERROR_ITEMPROTECTED" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21u&open=AZ0G_MrxJsw9t8RWl21u&pullRequest=1666

Check failure on line 54 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ITEMTITLE" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21Y&open=AZ0G_MrxJsw9t8RWl21Y&pullRequest=1666

Check failure on line 53 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_DELITEM" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21X&open=AZ0G_MrxJsw9t8RWl21X&pullRequest=1666

Check failure on line 58 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ITEMSUFFIX" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21c&open=AZ0G_MrxJsw9t8RWl21c&pullRequest=1666

Check failure on line 92 in htdocs/modules/system/language/english/modinfo.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_MI_SYSTEM_MENUS_ACTIVE" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MscJsw9t8RWl211&open=AZ0G_MscJsw9t8RWl211&pullRequest=1666

Check warning on line 430 in htdocs/modules/system/include/update.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "system_menu_seed_permissions" to match the regular expression ^[a-z][a-zA-Z0-9]*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MtnJsw9t8RWl21-&open=AZ0G_MtnJsw9t8RWl21-&pullRequest=1666

Check failure on line 147 in htdocs/kernel/menuscategory.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "readonly="readonly"" 3 times. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MuDJsw9t8RWl22C&open=AZ0G_MuDJsw9t8RWl22C&pullRequest=1666

Check warning on line 1069 in htdocs/class/theme.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant jump. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0H7qkQjy-9gvRaO0EX&open=AZ0H7qkQjy-9gvRaO0EX&pullRequest=1666

Check failure on line 42 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_CATSUFFIX" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21O&open=AZ0G_MrxJsw9t8RWl21O&pullRequest=1666

Check failure on line 83 in htdocs/modules/system/language/english/admin/menus.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "_AM_SYSTEM_MENUS_ERROR_ITEMPARENT" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 

See more on https://sonarcloud.io/project/issues?id=XOOPS_XoopsCore25&issues=AZ0G_MrxJsw9t8RWl21v&open=AZ0G_MrxJsw9t8RWl21v&pullRequest=1666
View more details on SonarQubeCloud