Skip to content

Fix/#83 : 폴더 커버 이미지 반영 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Darren4641 merged 14 commits into from
Jan 28, 2026
Merged

Fix/#83 : 폴더 커버 이미지 반영 #86

Darren4641 merged 14 commits into from
Jan 28, 2026

Conversation

@koosco
Copy link
Member

@koosco koosco commented Jan 28, 2026 •
edited
Loading

summary

  • 폴더 목록 조회시 커버 이미지와 사진 개수를 포함하도록 수정
  • 폴더별 사진 목록 조회 API 버그 수정

details

폴더 목록 조회시 커버 이미지와 사진 개수를 포함하도록 수정

  • 폴더 목록 조회시 커버 이미지와 사진 개수를 포함하여 응답하도록 수정합니다
    • 폴더의 사진은 최신 업로드된 사진입니다
  • 여러 폴더에 해당하는 삭제할 때, 사진이 폴더 커버 이미지인 경우 삭제되는 이미지를 제외한 나머지 사진 중 최신 사진으로 변경됩니다
  • 현재는 폴더 내부에서만 삭제할 수 있지만 전체 사진 조회에서 삭제가 필요한 경우 대비
  • 사진 업로드를 하는 경우 최신 사진으로 폴더 커버 이미지가 업데이트됩니다

폴더별 사진 목록 조회 API 버그 수정

  • 사진 목록을 조회할 때 folderId가 전달되지 않는 에러를 수정
    • 폴더 내에서 사진을 호출해도 전체 사진이 반환되는 오류

@koosco koosco self-assigned this Jan 28, 2026
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Code Format Check ✅ PASSED

Spotless Check: success

✨ All code formatting checks passed!

Pushed by: @koosco, Action: pull_request

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Test ✅ PASSED

Test Result: success

✨ All tests passed!

Pushed by: @koosco, Action: pull_request

@koosco koosco marked this pull request as draft January 28, 2026 08:09
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Code Format Check ✅ PASSED

Spotless Check: success

✨ All code formatting checks passed!

Pushed by: @koosco, Action: pull_request

@koosco koosco marked this pull request as ready for review January 28, 2026 09:18
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Test ✅ PASSED

Test Result: success

✨ All tests passed!

Pushed by: @koosco, Action: pull_request

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Code Format Check ✅ PASSED

Spotless Check: success

✨ All code formatting checks passed!

Pushed by: @koosco, Action: pull_request

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Test ✅ PASSED

Test Result: success

✨ All tests passed!

Pushed by: @koosco, Action: pull_request

Darren4641
Darren4641 reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@Darren4641 Darren4641 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마이너 이슈 코멘트 추가했습니다!

src/main/kotlin/com/yapp2app/photo/application/result/FolderResult.kt Outdated

data class GetFoldersResult(val items: List<FolderInfo>) {
data class FolderInfo(val folderId: Long, val name: String)
data class FolderInfo(val folderId: Long, val name: String, val imageObjectKey: String?, val count: Long)
Copy link
Contributor

@Darren4641 Darren4641 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 어그리거트 처럼 변수명을 통일하면 좋을 것 같습니다!

Suggested change
data class FolderInfo(val folderId: Long, val name: String, val imageObjectKey: String?, val count: Long)
data class FolderInfo(val folderId: Long, val name: String, val storageKey: String?, val count: Long)

src/main/kotlin/com/yapp2app/photo/application/port/PhotoImageRepositoryPort.kt Outdated
/**
* 삭제 예정인 사진들이 속한 폴더 ID 조회
*/
fun getAffectedFolderIds(userId: Long, photoIds: List<Long>): List<Long>
Copy link
Contributor

@Darren4641 Darren4641 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미사용 코드 제거

src/main/kotlin/com/yapp2app/photo/infra/persist/jpa/PhotoImageQueryRepository.kt Outdated
.execute().toInt()
}

fun getAffectedFolderIds(userId: Long, photoIds: List<Long>): List<Long> {
Copy link
Contributor

@Darren4641 Darren4641 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미사용 코드 제거

src/main/kotlin/com/yapp2app/photo/infra/persist/PhotoImageRepositoryAdapter.kt Outdated
override fun updatePhotosFolderIdToNull(userId: Long, folderIds: List<Long>): Int =
queryRepository.updatePhotosFolderIdToNull(userId, folderIds)

override fun getAffectedFolderIds(userId: Long, photoIds: List<Long>): List<Long> =
Copy link
Contributor

@Darren4641 Darren4641 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미사용 코드 제거

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Code Format Check ✅ PASSED

Spotless Check: success

✨ All code formatting checks passed!

Pushed by: @koosco, Action: pull_request

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Test ✅ PASSED

Test Result: success

✨ All tests passed!

Pushed by: @koosco, Action: pull_request

@Darren4641 Darren4641 merged commit d036d9a into staging Jan 28, 2026
2 checks passed
@Darren4641 Darren4641 deleted the fix/#83 branch January 28, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Darren4641 Darren4641 Darren4641 left review comments

Assignees

@koosco koosco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koosco @Darren4641