-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/#83 : 폴더 커버 이미지 반영 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ac5cda7
chore: UpdatePhotoFavoriteRequest.kt 파일 통합
koosco 785f7dc
fix : 폴더 목록 API에 사진 개수, 커버 사진 포함
koosco cc70133
fix : 사진 삭제, 생성 시 폴더 커버 사진 업데이트
koosco a638677
chore : 폴더 커버 flyway schema 반영
koosco efa40dc
fix : 사진 목록 조회시 폴더 조건 추가
koosco 10cac47
ref : 폴더 목록 조회 쿼리 개선
koosco 8aef52e
test : 폴더 커버 갱신 test 추가
koosco 8e78f0e
docs: presigned url 주석의 api endpoint 수정
koosco a90c66c
fix: folder 커버 이미지 생성 시간 제거
koosco 3527b24
fix: 조회 시점에 앨범 커버 이미지를 조인하도록 수정
koosco 1306ced
fix: 사용하지 않는 메서드 제거
koosco 08b881a
fix: 즐겨찾기 이미지 url을 usecase에서 분리
koosco eb4461f
fix: Folder storageKey 변수명 통일
koosco 19d5333
fix: PhotoImageQueryRepository.kt 미사용 코드 제거
koosco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
16 changes: 0 additions & 16 deletions
16
src/main/kotlin/com/yapp2app/photo/api/dto/UpdatePhotoFavoriteRequest.kt
This file was deleted.
Oops, something went wrong.
14 changes: 14 additions & 0 deletions
14
src/main/kotlin/com/yapp2app/photo/application/contract/FolderWithStats.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package com.yapp2app.photo.application.contract | ||
|
|
||
| /** | ||
| * fileName : FolderWithStats | ||
| * author : koo | ||
| * date : 2026. 1. 28. | ||
| * description : Folder with aggregated statistics (photo count and cover image info) | ||
| */ | ||
| data class FolderWithStats( | ||
| val folderId: Long, | ||
| val name: String, | ||
| val coverImageStorageKey: String?, | ||
| val photoCount: Long, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,5 +9,5 @@ package com.yapp2app.photo.application.result | |||||
| data class CreateFolderResult(val folderId: Long) | ||||||
|
|
||||||
| data class GetFoldersResult(val items: List<FolderInfo>) { | ||||||
| data class FolderInfo(val folderId: Long, val name: String) | ||||||
| data class FolderInfo(val folderId: Long, val name: String, val imageObjectKey: String?, val count: Long) | ||||||
|
||||||
| data class FolderInfo(val folderId: Long, val name: String, val imageObjectKey: String?, val count: Long) | |
| data class FolderInfo(val folderId: Long, val name: String, val storageKey: String?, val count: Long) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,10 +31,11 @@ class PhotoImageRepositoryAdapter( | |
|
|
||
| override fun listOwnedPhotosWithFavorite( | ||
| userId: Long, | ||
| folderId: Long?, | ||
| offset: Int, | ||
| limit: Int, | ||
| sortOrder: SortOrder, | ||
| ): List<PhotoWithFavorite> = queryRepository.findOwnedPhotosWithFavorite(userId, offset, limit, sortOrder) | ||
| ): List<PhotoWithFavorite> = queryRepository.findOwnedPhotosWithFavorite(userId, folderId, offset, limit, sortOrder) | ||
|
|
||
| override fun listOwnedFavoritePhotos( | ||
| userId: Long, | ||
|
|
@@ -65,4 +66,7 @@ class PhotoImageRepositoryAdapter( | |
|
|
||
| override fun updatePhotosFolderIdToNull(userId: Long, folderIds: List<Long>): Int = | ||
| queryRepository.updatePhotosFolderIdToNull(userId, folderIds) | ||
|
|
||
| override fun getAffectedFolderIds(userId: Long, photoIds: List<Long>): List<Long> = | ||
|
||
| queryRepository.getAffectedFolderIds(userId, photoIds) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
미사용 코드 제거