Improve nested list assignments #4555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are multiple unrelated changes in the same PR, can you separate them into one change per commit? |
|
Also, can you please look into adding some test cases for these features? Without them, we might accidentally break them in the future. |
widlarizer
reviewed
Aug 20, 2024
frontends/verilog/Makefile.inc
Outdated
| @@ -6,7 +6,7 @@ GENFILES += frontends/verilog/verilog_lexer.cc | |||
|
|
|||
| frontends/verilog/verilog_parser.tab.cc: frontends/verilog/verilog_parser.y | |||
| $(Q) mkdir -p $(dir $@) | |||
| $(P) $(BISON) -Wall -Werror -o $@ -d -r all -b frontends/verilog/verilog_parser $< | |||
| $(P) $(BISON) --debug -Wall -Werror -o $@ -d -r all -b frontends/verilog/verilog_parser $< | |||
There was a problem hiding this comment.
Was this left in by accident?
There was a problem hiding this comment.
Yeah, oops, I'll fix that, one moment
There was a problem hiding this comment.
Fixed, rebased and push -f
Please review again
A list can either start with '{ or {, this commit fixes this
leviathanch
force-pushed
the
systemverilog1
branch
from
7b9bf29
to
173f591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered some issues when trying to synthesize the most recent Rocket Core with Yosys,
those changes fix those issues and now all that's left is to solve the issues with automatic logic
inside an always block