Fix failing macOS CI runs #5319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also skip `brew update`. Specify llvm@20 due to problems with clang-21 and macOS .dylib.
KrystalDelusion
force-pushed
the
krys/brew_bundle
branch
from
75b32f5 to
2261c7e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
The sans bundle dependencies didn't include |
mmicko
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
https://yosyshq.discourse.group/t/psa-llvm21-on-macos-is-failing-yosys-builds/76
Explain how this is achieved.
Specify
llvm@20in brewfile, and use the brewfile for macOS CI runs.Also add macos-latest to test-compile.
Note that setting macOS compilers to specify clang-19 passes C++17, but fails C++20 (on both x86 and arm) despite passing both C++ versions under ubuntu, spun out to #5320.
If applicable, please suggest to reviewers how they can test the change.