fix: select pyosys bugs and object lifecycle issues #5441
+131
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- class properties are now always bridged as references if they're pointers or containers, and by value otherwise - resolves an issue with python copies of `.name` not incrementing the IdString's refcount - add new overload of RTLIL::Module: addMemory that does not require a "donor" object - the idea is `Module`, `Memory`, `Wire`, `Cell` and `Process` cannot be directly constructed in Python and can only be added to the existing memory hierarchy in `Design` using the `add` methods - `Memory` requiring a donor object was the odd one out here - fix superclass member wrapping only looking at direct superclass for inheritance instead of recursively checking superclasses - fix superclass member wrapping not using superclass's denylists - fix Design's `__str__` function not returning a string - fix the generator crashing if there's any `std::function` in a header - misc: add a crude `__repr__` based on `__str__`
donn
changed the title
mmicko
reviewed
Oct 22, 2025
|
Would like to ping @jix and @georgerennie on this one as well |
|
I should mention for the record there's another lifecycle issue left which is dangling references behave a lot like C++. The way the boost bindings handled that is by keeping the entire design in memory if any references to even like, an IdString key in |
|
Actually, let me think about this one a bit more. The copy by value solution is also kind of a hack — because if A and B are classes and A has a non-pointer member of type B, a.b.x = 0 would mutate a copy. This will confuse people. The current semantics are consistent despite the memory issues. I just need to fix the memory issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Explain how this is achieved.
.namenot incrementing the IdString's refcountModule,Memory,Wire,CellandProcesscannot be directly constructed in Python and can only be added to the existing memory hierarchy inDesignusing theaddmethods -Memoryrequiring a donor object was the odd one out here__str__function not returning a stringstd::functionin a header__repr__based on__str__Make sure your change comes with tests. If not possible, share how a reviewer might evaluate it.
With a Yosys compiled with ENABLE_PYTHON,
python3 ./tests/pyosys/run_tests.py yosys