PLAYGROUND NEVER MERGE: Playground/workgroup debugger #124
+2,576
−889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zorro666
force-pushed
the
playground/workgroup-debugger
branch
6 times, most recently
from
58d8d57 to
6c4789d
Compare
Zorro666
force-pushed
the
playground/workgroup-debugger
branch
8 times, most recently
from
094a041 to
e78a5be
Compare
Zorro666
force-pushed
the
playground/workgroup-debugger
branch
4 times, most recently
from
2b1bcf9 to
daeff53
Compare
Zorro666
force-pushed
the
playground/workgroup-debugger
branch
6 times, most recently
from
915ac09 to
6eb868b
Compare
Zorro666
force-pushed
the
playground/workgroup-debugger
branch
3 times, most recently
from
3c4bfa9 to
ed5854f
Compare
Zorro666
force-pushed
the
playground/workgroup-debugger
branch
from
dbf63f2 to
0bd8148
Compare
Useful for multi-threaded use of VulkanCreationInfo to guarantee it can't be accidentally mutated. Primary usage is for SPRIV shader debugging. Change existing VulkanDebugManager helpers to use the new helpers
Adds to an MT safe queue which is processed on the debugger device thread Made ClampScalars static methods become Debugger helper member functions
Thread Simulation queues MathOp, SampleGatherOp requests and then the Thread is paused. The Debugger loop processes the MathOp queue, batches MathOps together into a single command list, Submit, Sync. The Debugger loop processes the SampleGatherOp queue, batches GPU SampleGatherOps together into a single command list, Submit, Sync. Some SampleGatherOps are run on the CPU and do not use the GPU. When the queued operations are completed, the results are written back into the Thread Simulation and the paused Threads are rerun.
Disabled by default : controlled by a debug config option More parts of apiWrapper and Debugger APIs need converting to be queued operations which run on the debugger thread and not on the Thread simulation thread
The Debugger APIs run on the device thread if required, FillInputValue(), ReadTexel(), WriteTexel()
Add read/write locking for containers "usedNames" and "dynamicNames"
Mark any pointer writes that require a callback to run on the device thread
ThreadState DeviceOpResult ReadPointerValue(Id pointer, ShaderVariable &ret); Debugger DeviceOpResult ReadFromPointer(const ShaderVariable &ptr, ShaderVariable &ret) const; DeviceOpResult GetPointerValue(const ShaderVariable &v, ShaderVariable &ret) const;
Run EnterFunction(), EnterEntryPoint(), ProcessScopeChange() on device thread
This reverts commit e8c11f2.
Removes need for a copy in job creation and removes need for activeMask member in ActiveTangleData
Zorro666
force-pushed
the
playground/workgroup-debugger
branch
from
5ba9e1f to
509fc25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.