enhancement - Client user colors#35
Open
Jackietkfrost wants to merge 6 commits intoachhayapathak:mainfrom
Open
enhancement - Client user colors#35Jackietkfrost wants to merge 6 commits intoachhayapathak:mainfrom
Jackietkfrost wants to merge 6 commits intoachhayapathak:mainfrom
Conversation
Made it so it selects a color from the list. This list is based on the stylesh package, and makes sure the selected color is a string to pass as a variable. Currently we're only coloring the border of the user, but could easily do the name itself, or the background of the text. Tried to make it as backwards compatible as possible.
clearing unused text line to help with multiline and text modification.
Added chat formatter to make chat automatically multiline when above that character count.
added blocker to send so empty messages don't get sent.
Author
|
How do I see what Snyk is saying has failed? That feels odd that I can't just see what the issue is so I can fix it. |
Author
|
Is the project dead? |
achhayapathak
approved these changes
Jul 23, 2025
Owner
|
Hey @Jackietkfrost, thanks for the contribution. I was focusing on another project, that's why I was inactive here. The vulnerability is in the stylesh package that you are using. I have approved the PR though. Let me know if you are fixing this otherwise I merge it! |
Author
|
That's awesome, @achhayapathak, hope the other project is getting well deserved care! What's the vulnerability in stylesh? If there's anything I can do to fix it, I'll try that. If I can't fix it, I'll ask for the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added user and system coloring schemes as well as borders to distinguish users. Added Stylesh package for this purpose, and this gives us access to ~140 colors that are randomly given to users on join.
Beside this, I've made it backwards compatible in the sense that if the server is not assigning a color index, or the client isn't using one, their default border will be 'white'. Overall it's a significant overhaul of what we have, but it's prettier, backwards compatible, and allows more freedom for eventually adding more content such as slash commands to change colors and such. Versioning was changed to 2.1.0, and also added in a line move to modify the sent input.
Currently known bugs:
<>will show on older clients instead of splitting content (This doesn't feel like too big of an issue)