-
Notifications
You must be signed in to change notification settings - Fork 367
New author system #6807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New author system #6807
Conversation
…g added multiple times)
|
I'm about to be offline for the day, but have pushed a number of fixes to [Edit: #6895]. It would be very helpful to have all these catalogued, but you'll want to cross-ref this against the fixes I've done. Sorry, I should have been more systematic with that. Here's another super-ambiguous one: https://aclanthology.org/P19-1140/. "Zhiyuan Li" appears to be a popular name. |
|
Also let's just commit changes directly in #6895? Instead of doing separate metadata changes? About to push one more then I'm off. |
Updated & pushed. |
Fix author metadata in preparation for the new author representation (#6807)
|
What do we do after the transition with metadata correction issues opened before the transition? Those which ask for changes concerning authors may use old ids that are no longer valid or have been appointed to someone else (e.g. catch-all ids for ambiguous names may then point to a specific person with ORCID info) Ideally, there should be only a few still open metadata corrections before we merge into master. For any "old" metadata correction we approve after the transition, we have to be careful regarding assignment of authors to ids. I know the bulk processing script needs to be adapted to the new library (and fix the reordering bug on the way). |
I see three options:
(1) seems hard, and there is also a race condition. (2) seems like a lot of work. I suggest we go with (3). To handle (3), we basically will know which are old and which are new, based on the transition date. The script will just take care not to trust IDs prior to that date. (The script should be setup to be wary of IDs, anyway, since they are user-editable, as you note). |
|
Would it be a good idea to make a post/reach out to stakeholders (ARR, EACL 2026) warning them that the author transition is coming? E.g.:
We are sure about no URLs breaking, right? Any current unverified author page will be forwarded to |
I could run another systematic comparison (build under old + new system and run a script to compare which pages are being generated) before we switch. Can't hurt to be too careful IMO.
Unless there’s a bug here that I haven’t caught, yes: acl-anthology/hugo/static/.htaccess Lines 84 to 87 in 4fc9af2
|
@mjpost thoughts on an advance announcement? It seems like a good way to address the fact that there are a lot of open correction issues, i.e. we are busy on important work and will get to those soon. :) |
|
Yes, we definitely need to do this. My thinking is:
|
|
https://preview.aclanthology.org/master-new-author-system-ui/people/yang-liu/unverified/:
https://preview.aclanthology.org/master-new-author-system-ui/people/yang-janet-liu/: Where are the Chinese characters coming from? I thought unverified = no entry in our database, so how would we be able to disambiguate the Chinese spelling of the name? Is this a bug in the API? |
|
^ It seems that if a |
|
Variants in foreign script can be recorded directly in the XML. EDIT: ...and if that author doesn't have an explicit ID, they're of course unverified. |
|
Ah. So my concern is, for the unverified Yang Liu page, 扬 刘 is but one possible Chinese variant of the name. Maybe it was the only one that happened to be present in an XML file where Yang Liu was unverified. But it seems misleading to show it in parentheses as if it represents ALL the unverified Yang Lius—some (presumably most) of whom didn't have a script variant in the XML. I don't know if this is a representation problem in the library, or if the page should just not show the alternate script variant on unverified authors. Maybe this logic should be modified to check verification: acl-anthology/bin/create_hugo_data.py Lines 387 to 396 in efd9fde
|
|
I don't see how this would be a representation problem in the library; the author tag with the name variant needs to be resolved to an ID, and that can be an unverified one. Still, the Han name variant belongs to that author ID, so it will be returned as one of the possible names for this unverified person. That does appear perfectly correct to me. |
|
If we were being really nitpicky we might distinguish script variants that occur with all instances of an unverified author from ones that occur only some of the time (because there can always be multiple people under the same unverified author and their names can have different script variants). But this feels like overkill, and I was able to implement a front-end change in #6824 that removes this source of confusion. |
|
If we were being really really nitpicky I would say different-script name variants don't really belong on the paper level at all, but instead could trigger/require a verified ID assignment so that the variant can be stored at the author level. :) |

I am opening this draft PR to produce a build in service of wrapping up the new author representation. Discussion here can largely continue from #5471.
List of TODO items
UI changes:
The following are important tasks, but need not block merging:
Administrative tasks: