fix(number-field): sp-number-field UI fixes for validation and width #5401
+145
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d8627a The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
castastrophe
force-pushed
the
caseyisonit/swc-669-icon-overlap-refresh
branch
from
16f982b to
2994a37
Compare
castastrophe
force-pushed
the
caseyisonit/swc-669-icon-overlap-refresh
branch
from
2994a37 to
1d8627a
Compare
Tachometer resultsChromenumber-field permalinkbasic-test
textfield permalinktest-basic
Firefoxnumber-field permalinkbasic-test
textfield permalinktest-basic
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
THIS IS A COPY OF PR #5326 -- it was going stale
Number Field had a number of issues related to the UI, default widths, and token modifiers. This PR addresses the following:
Related issue(s)
Motivation and context
Number Field should be customizable, have a default width based on design docs, and have validation icons and input truncation render correctly.
How has this been tested?
_Review the VRTs and ensure no unexpected side effects happen in other components
Check validation icons render correctly
Check you can modify the width via mod token
sp-number-fieldin dev tools--mod-stepper-width: 500pxto the host levelCheck you can modify the width via width
sp-number-fieldin dev toolswidth: 500pxto the host levelSlider [editable] number field should fill the available grid column
sp-sliderin dev toolssp-sliderdom nodeSlider [editable] number field should size correctly when grid column is modified
sp-sliderin dev tools--mod-stepper-width: 80px;to the sliderDid it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.