-
Notifications
You must be signed in to change notification settings - Fork 229
fix(number-field): sp-number-field UI fixes for validation and width #5408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(number-field): sp-number-field UI fixes for validation and width #5408
Conversation
- removes hardcoded styles for widths Co-authored-by: Casey Eickhoff <[email protected]>
Co-authored-by: Casey Eickhoff <[email protected]>
🦋 Changeset detectedLatest commit: 482b418 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsChromenumber-field permalinkbasic-test
Firefoxnumber-field permalinkbasic-test
|
- removes hardcoded styles for widths Co-authored-by: Casey Eickhoff <[email protected]>
Co-authored-by: Casey Eickhoff <[email protected]>
275942c
to
c5a4fb4
Compare
@TarunAdobe Uh oh- we may not have updated the links in the PR description. That looks like the old branch. Can you try this link instead? https://marissahuysentruyt-number-field-swc-669-test--spectrum-wc.netlify.app/storybook/?path=/story/number-field--validation-icons&globals=system:spectrum-two It should look like this: ![]() |
Co-authored-by: Casey Eickhoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Co-authored-by: Casey Eickhoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOU ARE AMAZING
….com:adobe/spectrum-web-components into marissahuysentruyt/number-field-swc-669-test
…5408) * docs(number-field): add number-field validation icon stories - removes hardcoded styles for widths Co-authored-by: Casey Eickhoff <[email protected]> * fix(number-field): implements spacing for validation icons Co-authored-by: Casey Eickhoff <[email protected]> * fix(numberfield): defines stepper width * chore: add changeset * chore: the teeniest tiniest lint fix * docs(number-field): add number-field validation icon stories - removes hardcoded styles for widths Co-authored-by: Casey Eickhoff <[email protected]> * fix(number-field): implements spacing for validation icons Co-authored-by: Casey Eickhoff <[email protected]> * fix(numberfield): defines stepper width * chore: add changeset * docs(numberfield): update readme Co-authored-by: Casey Eickhoff <[email protected]> * fix(numberfield): lint fix Co-authored-by: Casey Eickhoff <[email protected]> * chore(numberfield): removes textfield from changeset * chore: update golden hash --------- Co-authored-by: Casey Eickhoff <[email protected]>
Description
THIS REPLACES #5401 AND #5326
Number Field had a number of issues related to the UI, default widths, and token modifiers. This PR addresses the following:
Related issue(s)
Motivation and context
Number Field should be customizable, have a default width based on design docs, and have validation icons and input truncation render correctly.
How has this been tested?
_Review the VRTs and ensure no unexpected side effects happen in other components
Check validation icons render correctly
Check you can modify the width via mod token
sp-number-field
in dev tools--mod-stepper-width: 500px
to the host levelCheck you can modify the width via width
sp-number-field
in dev toolswidth: 500px
to the host levelSlider [editable] number field should fill the available grid column
sp-slider
in dev toolssp-slider
dom nodeSlider [editable] number field should size correctly when grid column is modified
sp-slider
in dev tools--mod-stepper-width: 150px;
to the sliderDid it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.