nixl_ep: Migrate elastic.py to TCPStore #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi itayalroy! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
@2dm @RoeyAzran1992 @ebarilanM to review |
Contributor
Author
|
/build |
Contributor
Author
|
/build |
Signed-off-by: Itay Alroy <[email protected]>
Signed-off-by: Itay Alroy <[email protected]>
This commit migrates elastic.py to TCPStore-based metadata exchange instead of ETCD. Note that this TCPStore instance can be re-used for rank management (instead of the custom TCP based implementation we currently have) but distributed rank management performs worse in scale (tested with 64 concurrent get_rank() calls) so rank server will stay for now. Signed-off-by: Itay Alroy <[email protected]>
Signed-off-by: Itay Alroy <[email protected]>
Contributor
Author
|
/build |
ebarilanM
approved these changes
Jan 8, 2026
Collaborator
ebarilanM
left a comment
ebarilanM
left a comment
There was a problem hiding this comment.
please open issue for solve external md exchange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates elastic.py to TCPStore-based metadata exchange
instead of ETCD.
Note that this TCPStore instance can be re-used for rank management
(instead of the custom TCP based implementation we currently have)
but distributed rank management performs worse in scale (tested
with 64 concurrent get_rank() calls) so rank server will stay
for now.