fix(helm): Add ingress template to workload-api-server#352
Closed
Catskan wants to merge 9 commits intoairbytehq:mainfrom
Closed
fix(helm): Add ingress template to workload-api-server#352Catskan wants to merge 9 commits intoairbytehq:mainfrom
Catskan wants to merge 9 commits intoairbytehq:mainfrom
Conversation
|
|
Catskan
force-pushed
the
catskan/add-ingress-template-fix
branch
from
ec7d5c0 to
0eef377
Compare
|
Catskan Octavia Squidington III (@octavia-squidington-iii) Any updated on the PR ? |
|
Any update on this MR? We're getting blocked on this issue as well, would be super helpful to push this through. |
Contributor
|
Hi we are consolidating the workload api into the airbyte server in a recent commit, so this change should no longer be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
By changing api-server by workload-api-server, ingress template is missing for workload_api_server while
values.yamlhave the capability to enable ingress for workload-api-server .So actually, workload-api-server is unable to create the related ingress.
How
Just add the ingress template to
charts/workload-api-server/templatesCan this PR be safely reverted and rolled back?