WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2#112
Closed
cloud-j-luna wants to merge 19 commits into
Closed
WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2#112cloud-j-luna wants to merge 19 commits into
cloud-j-luna wants to merge 19 commits into
Conversation
faabd57 to
17eb424
Compare
Member
Author
|
Previously closed issue #86 |
troian
reviewed
Apr 18, 2023
troian
requested changes
Apr 18, 2023
Member
|
i'll summarize requests here so it would be easier to follow
// sslEnable is a string type
if sslEnable != "" && sslEnable == "1" {do // sslEnable is a bool type
if sslEnable {provider run would be a good place to start |
Member
|
i marked it as WIP until all issues are resolved. feel free to remove when done |
…into luna/tls-cert-manager
ghost
reviewed
Sep 6, 2024
| --version $(PROMTAIL_VERSION) \ | ||
| --namespace loki-stack \ | ||
| -f ../promtail-values.yaml | ||
| -f ../promtail-values.yamlk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows cert-manager annotations on ingress based on environment variables.