Skip to content

WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2#112

Closed
cloud-j-luna wants to merge 19 commits into
akash-network:mainfrom
quasarch:luna/tls-cert-manager
Closed

WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2#112
cloud-j-luna wants to merge 19 commits into
akash-network:mainfrom
quasarch:luna/tls-cert-manager

Conversation

@cloud-j-luna

Copy link
Copy Markdown
Member

This PR allows cert-manager annotations on ingress based on environment variables.

@cloud-j-luna cloud-j-luna requested review from boz and troian as code owners April 18, 2023 19:00
@cloud-j-luna cloud-j-luna force-pushed the luna/tls-cert-manager branch from faabd57 to 17eb424 Compare April 18, 2023 19:06
@cloud-j-luna

Copy link
Copy Markdown
Member Author

Previously closed issue #86

Comment thread cluster/util/environment.go Outdated
Comment thread cluster/kube/config.go Outdated
Comment thread operator/hostnameoperator/hostname_operator.go Outdated
@troian

troian commented Apr 18, 2023

Copy link
Copy Markdown
Member

i'll summarize requests here so it would be easier to follow

  • we use viper as interface to parse and prevalidate configuration parameter that can be defined using:
    • default values
    • config file
    • env variables
    • flags
  • don't define env variables, but flags instead, each flag will have env variable automatically by Viper (refer to it's documentation if you are eager to know how it works). for example --home flag will have AKASH_HOME env variable bound to it.
  • the configuration must be evaluated and validated within command handler and all subsequent instantiation must use go types corresponding to its values. think it this way: type safety is a top priority
  • if value can take only two states then bool would be the correct type. for example
    instead
// sslEnable is a string type
if sslEnable != "" && sslEnable == "1" {

do

// sslEnable is a bool type
if sslEnable {

provider run would be a good place to start

@troian troian changed the title feat: allow cert-manager annotations on ingress based on environment variables PT.2 WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2 Apr 20, 2023
@troian

troian commented Apr 20, 2023

Copy link
Copy Markdown
Member

i marked it as WIP until all issues are resolved. feel free to remove when done

@cloud-j-luna cloud-j-luna changed the title WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2 feat: allow cert-manager annotations on ingress based on environment variables PT.2 Apr 21, 2023
@cloud-j-luna cloud-j-luna changed the title feat: allow cert-manager annotations on ingress based on environment variables PT.2 WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2 Apr 23, 2023
Comment thread _run/common-helm.mk
--version $(PROMTAIL_VERSION) \
--namespace loki-stack \
-f ../promtail-values.yaml
-f ../promtail-values.yamlk

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be yamlk?

@vertex451 vertex451 closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants