chore(tooling): setup GitHub actions, add CODEOWNERS and PR template #20
Conversation
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| node: ['16'] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '11' | ||
|
|
||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
| cache: 'yarn' | ||
| cache-dependency-path: 'yarn.lock' |
There was a problem hiding this comment.
I wonder if we can add this whole part to a local GH action, will check 🤔
shortcuts
force-pushed
the
chore/github-actions
branch
from
a918eeb
to
a59eac0
Compare
|
|
||
| on: [push] | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
This job could depend on specs because it won't build with invalid spec.
There was a problem hiding this comment.
Done, apparently the workflow_run option is only triggered when deployed on the main branch, which seems odd 🤔
There was a problem hiding this comment.
From what I remember when I worked on Github Actions, there are a bunch of things that worked only on main and not on prs, this was quite an annoying limitation :(
There was a problem hiding this comment.
Will see once this PR is merged and will fix if it's not the case!
|
|
||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 |
There was a problem hiding this comment.
Can you link this to .nvmrc ? It's seems possible but not supported by default: issue
There was a problem hiding this comment.
good idea, seems to work this way: https://github.com/actions/setup-node/blob/d08cf222111d5c1d21b3cd4b958937f818d10d9a/docs/advanced-usage.md#node-version-file
done in: 9d2b059
There was a problem hiding this comment.
This feature was released just 5 hours ago ! I think the github cache is not updated yet:
Warning: Unexpected input(s) 'node-version-file', valid inputs are ['always-auth', 'node-version', 'architecture', 'check-latest', 'registry-url', 'scope', 'token', 'cache', 'cache-dependency-path', 'version']
There was a problem hiding this comment.
Maybe you can pin setup-node to version 2.5.0 ? 🤔
There was a problem hiding this comment.
Maybe you can pin setup-node to version 2.5.0
It seems to work now!
shortcuts
force-pushed
the
feat/recommend-spec
branch
from
36749c2
to
7f9c932
Compare
shortcuts
force-pushed
the
chore/github-actions
branch
from
fb35317
to
16c597b
Compare
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-180
Changes included :
buildandvalidatespec filesgenerate,buildandlintJavaScript clientCODEOWNERSfilePULL_REQUEST_TEMPLATEfile🧪 Test