-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tooling): setup GitHub actions, add CODEOWNERS and PR template #20
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a2e62fc
feat(specs): add `settings` spec
shortcuts 459e628
feat(specs): add `recommend` spec and client
shortcuts 07aeafe
chore(tooling): setup GitHub actions, add CODEOWNERS and PR template
shortcuts a59eac0
fix: lint commands
shortcuts 1345338
fix: PR template, run `client_javascript` on `specs` success
shortcuts 508eb47
fix: remove `strategy`, handle `failure` on `client_javascript`
shortcuts 9d2b059
fix: use node version from `.nvmrc`
shortcuts 16c597b
merge main
shortcuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Default owners | ||
|
|
||
| - @algolia/data-ingestion |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| ## 🧭 What and Why | ||
|
|
||
| 🎟 JIRA Ticket: | ||
|
|
||
| ### Changes included: | ||
|
|
||
| - List changes | ||
|
|
||
| ## 🧪 Test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| name: client_javascript | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ['specs'] | ||
| types: | ||
| - completed | ||
|
|
||
| jobs: | ||
| build: | ||
| if: ${{ github.event.workflow_run.conclusion == 'success' }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '11' | ||
|
|
||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
| cache-dependency-path: 'yarn.lock' | ||
|
|
||
| - name: Install Dependencies | ||
| run: yarn install | ||
|
|
||
| - name: Generate search client | ||
| run: yarn generate:js:search | ||
|
|
||
| - name: Build search client | ||
| run: yarn client:build-js:search | ||
|
|
||
| - name: Generate recommend client | ||
| run: yarn generate:js:recommend | ||
|
|
||
| - name: Build recommend client | ||
| run: yarn client:build-js:recommend | ||
|
|
||
| - name: Lint | ||
| run: yarn prettier --check clients/algoliasearch-client-javascript | ||
|
|
||
| build-failure: | ||
| if: ${{ github.event.workflow_run.conclusion == 'failure' }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Error on `specs` workflow | ||
| run: exit 1 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: specs | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '11' | ||
|
|
||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'yarn' | ||
| cache-dependency-path: 'yarn.lock' | ||
|
|
||
| - name: Install Dependencies | ||
| run: yarn install | ||
|
|
||
| - name: Build | ||
| run: yarn build:spec | ||
|
|
||
| - name: Validate | ||
| run: yarn validate | ||
|
|
||
| - name: Lint | ||
| run: yarn prettier --check specs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job could depend on
specsbecause it won't build with invalid spec.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, apparently the
workflow_runoption is only triggered when deployed on the main branch, which seems odd 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I remember when I worked on Github Actions, there are a bunch of things that worked only on main and not on prs, this was quite an annoying limitation :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will see once this PR is merged and will fix if it's not the case!