Add config.hosts configuration to production #1002
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahseewhy
force-pushed
the
configure-config-hosts
branch
from
46a1c63 to
4359582
Compare
lfdebrux
reviewed
Dec 18, 2025
lib/host_patterns.rb
Outdated
| module HostPatterns | ||
| DEFAULT_HOST_PATTERNS = [ | ||
| /forms\.service\.gov\.uk/, | ||
| /www.forms\.service\.gov\.uk/, |
Member
There was a problem hiding this comment.
Suggested change
| /www.forms\.service\.gov\.uk/, | |
| /www\.forms\.service\.gov\.uk/, |
Contributor
Author
There was a problem hiding this comment.
Good catch! Better than the regex checker I used.
Member
There was a problem hiding this comment.
Oh and I think we need a regex for environments other than prod:
Suggested change
| /www.forms\.service\.gov\.uk/, | |
| /www\.forms\.service\.gov\.uk/, | |
| /www\.[^.*]*\.forms\.service\.gov\.uk/, |
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1002.www.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
lfdebrux
reviewed
Dec 18, 2025
* Add config.hosts configuration to production and a HostPatterns module * Add an allowed hosts list based on the `forms.service.gov.uk` domain (there are fewer items on this list because the configuration for `forms-product-page differs slightly from `forms-runner` and `forms-admin`; this list should be sense-checked by another developer) * This aligns `forms-product-page` with how config.hosts is configured in `forms-admin` and `forms-runner`
sarahseewhy
force-pushed
the
configure-config-hosts
branch
from
4359582 to
901af8b
Compare
* It looks like forms.service.gov.uk always redirects to www.forms.service.gov.uk * We don't want requests going to the app from a host header that's just forms.service.gov.uk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Secure forms-runner from potential unwanted vulnerability scanning by enforcing a list of allowed hosts. Very similar to PR#1803 in
forms-runner(see link).This aligns
forms-product-pagewith howforms-adminandforms-runnerconfigures its config.hosts (see this link).Note: The list of default host patterns is based on my understanding of how we use the
www.forms.service.gov.ukdomain. I may be missing some context so do have a look to make sure I've not missed a variation on that domain or added anything which isn't necessary. I've also put the regex patterns through a regex checker just in case.