Skip to content

Add config.hosts configuration to production #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarahseewhy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add config.hosts configuration to production #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
901af8b
Add config.hosts configuration to production
sarahseewhy Dec 18, 2025
ba2def9
Remove unnecessary default host pattern
sarahseewhy Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions config/environments/production.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
require "active_support/core_ext/integer/time"
require_relative "../../lib/host_patterns"

Rails.application.configure do
# Settings specified here will take precedence over those in config/application.rb.
Expand Down Expand Up @@ -57,11 +58,8 @@
config.i18n.fallbacks = true

# Enable DNS rebinding protection and other `Host` header attacks.
# config.hosts = [
# "example.com", # Allow requests from example.com
# /.*\.example\.com/ # Allow requests from subdomains like `www.example.com`
# ]
#
config.hosts = HostPatterns.allowed_host_patterns

# Skip DNS rebinding protection for the default health check endpoint.
# config.host_authorization = { exclude: ->(request) { request.path == "/up" } }
end
12 changes: 12 additions & 0 deletions lib/host_patterns.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
module HostPatterns
DEFAULT_HOST_PATTERNS = [
/www\.forms\.service\.gov\.uk/,
/pr-[^.]*\.www\.review\.forms\.service\.gov\.uk/,
].freeze

def self.allowed_host_patterns
additional_patterns = ENV.fetch("ALLOWED_HOST_PATTERNS", "").split(",").map { |pattern| Regexp.new(pattern.strip) }

[*DEFAULT_HOST_PATTERNS, *additional_patterns]
end
end
Loading