feat(generate): implement UI for ng generate #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ng generate implementation Fixes angular-klingon#5
…issue5-generate
UI Generate (in progress) Fixes angular-klingon#5
generate UI Fixes angular-klingon#5
…issue5-generate
manekinekko
requested changes
Dec 3, 2018
|
|
||
| subscribeToNgCreate() { | ||
| this.cliService.onNgCreate.subscribe((data: Subject<CommandResult>) => { | ||
| data.subscribe((response: any) => { |
There was a problem hiding this comment.
you can try and use a flatMap here, to avoid the double subscription.
There was a problem hiding this comment.
@manekinekko Added. And multiple component generate feature is also added.
UI for ng generate Fixes angular-klingon#5
sumitparakh
commented
Dec 9, 2018
| @@ -1,8 +1,11 @@ | |||
| import { Component, ViewChild } from '@angular/core'; | |||
| import { FormGroup, FormControl, Validators } from '@angular/forms'; | |||
There was a problem hiding this comment.
Removed unused imports.
…issue5-generate
sumitparakh
commented
Dec 9, 2018
| @@ -1,7 +1,5 @@ | |||
| import { FlagsComponent } from './../flags/flags.component'; | |||
| import { CliService } from './../cli.service'; | |||
| import { Validators } from '@angular/forms'; | |||
There was a problem hiding this comment.
Removed unused imports
refactoring Fixes angular-klingon#5
manekinekko
requested changes
Dec 9, 2018
…issue5-generate
…nto issue5-generate
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
sumitparakh
force-pushed
the
issue5-generate
branch
from
e9d202c
to
faa18c1
Compare
generate UI Fixes angular-klingon#5
generate ui Fixes angular-klingon#5
ui generate Fixes angular-klingon#5
ui generate Fixes angular-klingon#5
ui generate Fixes angular-klingon#5
ui generate Fixes angular-klingon#5
service worker, application, app shells, guards, library, universals wip
…nto issue5-generate
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng generate implementation
Closes #5