-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generate): implement UI for ng generate #75
Open
sumitparakh
wants to merge
19
commits into
angular-klingon:master
Choose a base branch
from
sumitparakh:issue5-generate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f595733
feat(generate): implement UI for ng generate
sumitparakh 352c61d
Merge branch 'master' of https://github.com/sumitparakh/klingon into …
sumitparakh d49d41d
feat(generate): implement UI for ng generate
sumitparakh 23a8891
feat(generate): implement UI for ng generate
sumitparakh ee095b2
Merge branch 'master' of https://github.com/sumitparakh/klingon into …
sumitparakh bc51c4c
feat(generate): generate multiple components
sumitparakh 603a5fa
Merge branch 'master' of https://github.com/sumitparakh/klingon into …
sumitparakh 4a3af52
feat(generate): some refactoring
sumitparakh 36d943d
Merge branch 'master' of https://github.com/sumitparakh/klingon into …
sumitparakh ae6b980
feat(generate): do not enable generate tab while running in dry mode
sumitparakh f793bd7
Merge branch 'master' of https://github.com/angular-klingon/klingon i…
sumitparakh 68f2fb8
feat(generate): classes generate support added
sumitparakh f453263
feat(generate): generate feature added for directives
sumitparakh de08554
feat(ui): generate feature for enum added
sumitparakh df0b77c
feat(ui): interface generate support added
sumitparakh faa18c1
feat(ui): module generate feature added
sumitparakh dcec136
feat(ui): pipe and service generate feature done
sumitparakh 096b361
feat(generate): ng components
sumitparakh d22f41d
Merge branch 'master' of https://github.com/angular-klingon/klingon i…
sumitparakh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
import { FlagsComponent } from './../flags/flags.component'; | ||
import { CliService } from './../cli.service'; | ||
import { Validators } from '@angular/forms'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed unused imports |
||
import { FormControl } from '@angular/forms'; | ||
import { FormGroup } from '@angular/forms'; | ||
import { Component, OnInit } from '@angular/core'; | ||
import { ImportService } from '../../_shared/utilities/import.service'; | ||
|
@@ -40,7 +38,9 @@ export class CliCreateComponent extends FlagsComponent implements OnInit { | |
const rootDir = this.form.value['root-dir']; | ||
localStorage.setItem('ui.lastUsedRootDirectory', rootDir || ''); | ||
|
||
// save application name to local storage to reuse it in generate tab | ||
const appName = this.form.value['directory'] || this.form.value['app-name']; | ||
localStorage.setItem('ui.appName', appName); | ||
|
||
this.isWorking = true; | ||
this.cli | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
packages/klingon-ui/src/app/cli/generate/component/component.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
<p *ngIf="form.get('components').controls.length === 0"> | ||
Please add component to continue | ||
</p> | ||
<app-drop-down *ngFor="let component of form.get('components').controls; let i = index"> | ||
<h3 class="title component-title"> | ||
<span> | ||
{{ component.value['component-name'] ? component.value['component-name'] : 'Component '+(i+1) }} | ||
</span> | ||
</h3> | ||
<h6 class="sub-title">Application Component</h6> | ||
<main class="content" [formGroup]="component"> | ||
|
||
<div class="component-form"> | ||
<p> | ||
<mat-form-field> | ||
<input formControlName="component-name" matInput placeholder="Name of the component to create in the app" | ||
required> | ||
<mat-hint align="start">Name of the component to create in the app</mat-hint> | ||
</mat-form-field> | ||
</p> | ||
<p> | ||
<mat-form-field> | ||
<mat-select formControlName="change-detection" placeholder="Specify change detection strategy for component (-c)"> | ||
<mat-option *ngFor="let value of changeDetection" [value]="value"> | ||
{{value}} | ||
</mat-option> | ||
</mat-select> | ||
<mat-hint align="start">Specify change detection strategy for component</mat-hint> | ||
</mat-form-field> | ||
</p> | ||
<p> | ||
<mat-form-field> | ||
<mat-select formControlName="styleext" placeholder="The file extension to be used for style files."> | ||
<mat-option *ngFor="let style of styleExt" [value]="style"> | ||
{{ style }} | ||
</mat-option> | ||
</mat-select> | ||
<mat-hint align="start">The file extension to be used for style files.</mat-hint> | ||
</mat-form-field> | ||
</p> | ||
<p> | ||
<mat-form-field> | ||
<input formControlName="module" matInput placeholder="Allows specification of the declaring module. (-m)"> | ||
<mat-hint align="start">Allows specification of the declaring module. (-m)</mat-hint> | ||
</mat-form-field> | ||
</p> | ||
<p> | ||
<mat-form-field> | ||
<input formControlName="prefix" matInput placeholder="The prefix to apply to generated selectors. (-p)"> | ||
<mat-hint align="start">The prefix to apply to generated selectors. (-p)</mat-hint> | ||
</mat-form-field> | ||
</p> | ||
<p> | ||
<mat-form-field> | ||
<input formControlName="project" matInput placeholder="The name of the project"> | ||
<mat-hint align="start">The name of the project</mat-hint> | ||
</mat-form-field> | ||
</p> | ||
<p> | ||
<mat-form-field> | ||
<input formControlName="selector" matInput placeholder="Selector"> | ||
<mat-hint align="start">The selector to use for the component.</mat-hint> | ||
</mat-form-field> | ||
</p> | ||
<p> | ||
<mat-list> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="dryRun">Run through without making any changes. (-d)</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="entry-component">Entry component</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="export">Specifies if declaring module exports the component.</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="flat">Flag to indicate if a dir is created.</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="force">Forces overwriting of files. (-f)</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="inline-style">Specifies if the style will be in the ts file. (-s)</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="inline-template">Specifies if the template will be in the ts file. (-t)</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="lint-fix">Specifies whether to apply lint fixes after generating the | ||
component.</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="skip-import">Flag to skip the module import.</mat-checkbox> | ||
</mat-list-item> | ||
<mat-list-item> | ||
<mat-checkbox formControlName="spec">Specifies if a spec file is generated.</mat-checkbox> | ||
</mat-list-item> | ||
</mat-list> | ||
</p> | ||
</div> | ||
</main> | ||
<div class="action"> | ||
<button mat-icon-button type="button" (click)="removeComponent(i);"> | ||
<mat-icon aria-label="Example icon-button with a heart icon">remove_circle</mat-icon> | ||
</button> | ||
</div> | ||
|
||
</app-drop-down> | ||
<mat-action-row> | ||
<button mat-mini-fab color="primary" type="button" (click)="addNewComponent($event)"> | ||
<i class="material-icons action"> | ||
add | ||
</i> | ||
</button> | ||
</mat-action-row> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed unused imports.