Welcome Page Redesign #55
Conversation
…aning up text styles for improved readability
|
The background patterns image is a placeholder and needs to be changed. Will change that once I receive the original one. |
app.json
Outdated
| "orientation": "portrait", | ||
| "newArchEnabled": true, | ||
| "icon": "./src/assets/images/icon.png", | ||
| "assetBundlePatterns": [ |
There was a problem hiding this comment.
expoBundlePatterns is deprecated, please elaborate.
| @@ -1,4 +1,5 @@ | |||
| import RootImageBackground from '@/components/RootImageBackground' | |||
There was a problem hiding this comment.
RootImageBackground has two platform specific implementations, a web version and native version (.tsx, .web.tsx), and they are getting replaced with a single version, was this done on purpose?
There was a problem hiding this comment.
The RootImageBackground.web.tsx is there but seems to be not used at all in any place.
There was a problem hiding this comment.
@Ajmaljalal that's a platform specific extension, have a look here https://docs.expo.dev/router/advanced/platform-specific-modules/
| fill: '#08786B' | ||
| } | ||
|
|
||
| switch (name) { |
There was a problem hiding this comment.
Could you use tailwind centralized color vars instead of hardcoding them?
src/assets/fonts/.keep
Outdated
There was a problem hiding this comment.
Why do we need this file/folder?
There was a problem hiding this comment.
removed, not needed for now. we can add when we need it, does not have to be before hand.
| orange: '#F29B00', | ||
| black: '#020202', | ||
| }, | ||
| fontFamily: { |
There was a problem hiding this comment.
Have you discussed the introduction of all these fonts with @waleedkadous?
There was a problem hiding this comment.
I removed the other fonts, the only one left is Exo2, which is the font used in the new design of the welcome page. @waleedkadous what are your thoughts?
There was a problem hiding this comment.
The current app background is greyish, is the whole app switching to the light background theme? How do the other pages look at the moment including the actual login and account registration pages?
There was a problem hiding this comment.
That is true, the current design change is only for the welcome page and all other pages including the login and the registration pages looks exactly as before. I am not 100% sure if we want to implement this. It introduces inconsistencies to the general theme of the app.
…s and improved styling consistency
2 participants
Welcome Page Redesign