-
Notifications
You must be signed in to change notification settings - Fork 11
Welcome Page Redesign #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
0436d3b
9a647ff
cc2b2c7
0df3a55
72c93b0
cdaa516
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The current app background is greyish, is the whole app switching to the light background theme? How do the other pages look at the moment including the actual login and account registration pages? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is true, the current design change is only for the welcome page and all other pages including the login and the registration pages looks exactly as before. I am not 100% sure if we want to implement this. It introduces inconsistencies to the general theme of the app. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from 'react' | ||
import { ImageBackground } from 'react-native' | ||
|
||
interface WelcomeRootImageBackgroundProps { | ||
children: React.ReactNode | ||
className?: string | ||
} | ||
|
||
const WelcomeRootImageBackground: React.FC<WelcomeRootImageBackgroundProps> = ({ children, className }) => { | ||
return ( | ||
<ImageBackground source={require('@/assets/images/welcome-background.png')} className={`flex-1 bg-white ${className}`}> | ||
{children} | ||
</ImageBackground> | ||
) | ||
} | ||
|
||
export default WelcomeRootImageBackground |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RootImageBackground has two platform specific implementations, a web version and native version (.tsx, .web.tsx), and they are getting replaced with a single version, was this done on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RootImageBackground.web.tsx is there but seems to be not used at all in any place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ajmaljalal that's a platform specific extension, have a look here https://docs.expo.dev/router/advanced/platform-specific-modules/