Skip to content

Conversation

@chegoryu
Copy link
Contributor

@chegoryu chegoryu commented Dec 1, 2025

Rationale for this change

Defaults were changed in this commit 1fcc892

What changes are included in this PR?

Fixed comments about default values of some writer properties

Are these changes tested?

No need to test

Are there any user-facing changes?

No

@chegoryu chegoryu requested a review from wgtmac as a code owner December 1, 2025 18:27
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@chegoryu chegoryu changed the title Fix *_write_page_index and size_statiscits comments MINOR: [Parquet] Fix *_write_page_index and size_statiscits comments Dec 1, 2025
@chegoryu chegoryu changed the title MINOR: [Parquet] Fix *_write_page_index and size_statiscits comments MINOR: [Parquet] Fix *_write_page_index and set_size_statistics_level comments Dec 1, 2025
@chegoryu chegoryu changed the title MINOR: [Parquet] Fix *_write_page_index and set_size_statistics_level comments MINOR: [C++][Parquet] Fix *_write_page_index and set_size_statistics_level comments Dec 1, 2025
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 2, 2025
@wgtmac
Copy link
Member

wgtmac commented Dec 2, 2025

Could you fix the lint error?

@wgtmac wgtmac merged commit 0879f5b into apache:main Dec 3, 2025
39 of 40 checks passed
@wgtmac wgtmac removed the awaiting committer review Awaiting committer review label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants