Skip to content

MINOR: [C++][Parquet] Fix *_write_page_index and set_size_statistics_level comments #48299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2025
Merged

MINOR: [C++][Parquet] Fix *_write_page_index and set_size_statistics_level comments #48299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ecc97f
Fix *_write_page_index and size_statiscits comments
chegoryu Dec 1, 2025
9338be6
fix
chegoryu Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions cpp/src/parquet/properties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ class PARQUET_EXPORT WriterProperties {
return this;
}

/// Enable writing page index in general for all columns. Default disabled.
/// Enable writing page index in general for all columns. Default enabled.
///
/// Writing statistics to the page index disables the old method of writing
/// statistics to each data page header.
Expand All @@ -715,35 +715,36 @@ class PARQUET_EXPORT WriterProperties {
return this;
}

/// Disable writing page index in general for all columns. Default disabled.
/// Disable writing page index in general for all columns. Default enabled.
Builder* disable_write_page_index() {
default_column_properties_.set_page_index_enabled(false);
return this;
}

/// Enable writing page index for column specified by `path`. Default disabled.
/// Enable writing page index for column specified by `path`. Default enabled.
Builder* enable_write_page_index(const std::string& path) {
page_index_enabled_[path] = true;
return this;
}

/// Enable writing page index for column specified by `path`. Default disabled.
/// Enable writing page index for column specified by `path`. Default enabled.
Builder* enable_write_page_index(const std::shared_ptr<schema::ColumnPath>& path) {
return this->enable_write_page_index(path->ToDotString());
}

/// Disable writing page index for column specified by `path`. Default disabled.
/// Disable writing page index for column specified by `path`. Default enabled.
Builder* disable_write_page_index(const std::string& path) {
page_index_enabled_[path] = false;
return this;
}

/// Disable writing page index for column specified by `path`. Default disabled.
/// Disable writing page index for column specified by `path`. Default enabled.
Builder* disable_write_page_index(const std::shared_ptr<schema::ColumnPath>& path) {
return this->disable_write_page_index(path->ToDotString());
}

/// \brief Set the level to write size statistics for all columns. Default is None.
/// \brief Set the level to write size statistics for all columns. Default is
/// PageAndColumnChunk.
///
/// \param level The level to write size statistics. Note that if page index is not
/// enabled, page level size statistics will not be written even if the level
Expand Down
Loading