Minor fixes on env vars and runtime for kubernetes #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vars used by quarkus need to be upper case and dots replaced by underscore to work
Now the ENV will be used on the command line (that was replaced from exec form to shell form of docker's CMD as in the the devmode docker image)
Without this the build fails. (was added too the possibility to configure other runtime with an env var)
davsclaus
reviewed
Aug 29, 2024
davsclaus
approved these changes
Aug 29, 2024
Not needed anymore since Hazelcast was replaced by plain maps
Not needed anymore since Hazelcast was replaced by plain maps
davsclaus
approved these changes
Sep 1, 2024
|
Thanks @thgruiz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: this is an awesome project!
This commits changes the following:
The vars on k8s deployment of the karavan-app
As all variables were lowercase, quarkus did not see them, resulting in errors (like not finding the git repo's URL)
Adds the JAVA_OPTS unused var to the command line used to run karavan-app
The var was been defined on the Dockerfile, but not used on the final command
With this change, It was replaced the docker 'exec form' with the 'shell form' so we can use the env var (or else we could not use it, as it has multiple values). I took caution to use the exec command to replace the shell by the java process (so it continues to receive OS signals)
Adds a default runtime to the build.sh script for k8s, or else when creating an integration using only the karavan-app on k8s (did not tested with vscode extension) de build was failing with 'The runtime option must be specified'
There are more stuff that I wish to contribute (for example: there is an error on git checkout when the repo's HEAD does not exist, even if we would not use it ), but let's see if those simple ones here are accepted first :)