Add ANSI support for Subtract #535 #593
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,6 +219,7 @@ message Subtract { | |||
| Expr right = 2; | |||
| bool fail_on_error = 3; | |||
| DataType return_type = 4; | |||
| EvalMode eval_mode = 5; | |||
There was a problem hiding this comment.
Just curious, if a Substrait plan was to send one of the options how it would map to this new functionality? How does ANSI map to an option?
https://substrait.io/extensions/functions_arithmetic/#subtract
| @@ -219,6 +219,7 @@ message Subtract { | |||
| Expr right = 2; | |||
| bool fail_on_error = 3; | |||
There was a problem hiding this comment.
Instead, set this fail_on_error to true when ANSI enabled.
There was a problem hiding this comment.
Okay. It makes sense & i will refactor, earlier i was referecing Abs.
|
I am planning to implement my solution as a extension to work done in #616 . Will resume once that PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #535
Rationale for this change
Part of #313
What changes are included in this PR?
How are these changes tested?