Skip to content

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Nov 25, 2025

What problem does this PR solve?

Invoke logRefreshExternalTable whenever ALTER TABLE … EXECUTE finishes so FE metadata stays in sync with external sources

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223 suxiaogang223 changed the title [fix](iceberg) Log refresh table after execute action [fix](iceberg) Add FE refresh logging after ALTER TABLE … EXECUTE Nov 25, 2025
@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34211 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c6ec9efa77927e8790e9c5577b5c2086b3fd7f4, data reload: false

------ Round 1 ----------------------------------
q1	17603	5084	4991	4991
q2	2072	309	208	208
q3	10236	1267	742	742
q4	10237	959	380	380
q5	7528	2373	2352	2352
q6	186	173	138	138
q7	930	781	634	634
q8	9352	1331	1085	1085
q9	7003	5268	5330	5268
q10	6816	2225	1814	1814
q11	482	309	288	288
q12	330	371	215	215
q13	17784	3621	3038	3038
q14	232	228	213	213
q15	598	518	505	505
q16	1028	1011	967	967
q17	596	885	368	368
q18	7761	7068	6951	6951
q19	1229	953	550	550
q20	344	342	240	240
q21	4138	3227	2319	2319
q22	1064	1015	945	945
Total cold run time: 107549 ms
Total hot run time: 34211 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5242	5007	4961	4961
q2	329	404	308	308
q3	2174	2647	2260	2260
q4	1336	1768	1329	1329
q5	4237	4496	4596	4496
q6	228	186	141	141
q7	2103	2071	1845	1845
q8	2624	2717	2661	2661
q9	7449	7603	7251	7251
q10	3065	3282	2758	2758
q11	591	525	506	506
q12	671	759	614	614
q13	3522	3901	3307	3307
q14	298	309	290	290
q15	556	506	546	506
q16	1128	1144	1076	1076
q17	1251	1566	1415	1415
q18	7725	7706	7651	7651
q19	815	890	937	890
q20	2037	2033	1959	1959
q21	4946	4474	4240	4240
q22	1099	1049	1010	1010
Total cold run time: 53426 ms
Total hot run time: 51474 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184356 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c6ec9efa77927e8790e9c5577b5c2086b3fd7f4, data reload: false

query1	1047	406	390	390
query2	6579	1619	1596	1596
query3	6759	226	229	226
query4	26010	22932	22500	22500
query5	5063	658	470	470
query6	348	249	231	231
query7	4659	515	317	317
query8	333	273	254	254
query9	8727	2627	2610	2610
query10	569	370	318	318
query11	15102	14824	14575	14575
query12	190	118	115	115
query13	1700	579	469	469
query14	11188	9073	8877	8877
query15	207	194	183	183
query16	7660	701	498	498
query17	1615	766	629	629
query18	2035	418	319	319
query19	205	207	167	167
query20	133	124	121	121
query21	221	135	113	113
query22	4016	3934	3767	3767
query23	33300	32009	31893	31893
query24	8445	2347	2388	2347
query25	566	527	453	453
query26	1235	272	161	161
query27	2758	522	365	365
query28	4372	2161	2136	2136
query29	820	606	490	490
query30	308	237	203	203
query31	845	722	632	632
query32	79	71	68	68
query33	593	372	336	336
query34	780	870	519	519
query35	800	828	753	753
query36	879	983	854	854
query37	124	106	86	86
query38	3293	3322	3321	3321
query39	1493	1401	1419	1401
query40	218	128	119	119
query41	84	64	60	60
query42	127	110	112	110
query43	471	492	435	435
query44	1245	752	759	752
query45	205	187	182	182
query46	896	1007	652	652
query47	1720	1728	1630	1630
query48	396	418	316	316
query49	790	492	424	424
query50	657	683	411	411
query51	3826	3956	3893	3893
query52	111	115	103	103
query53	244	264	187	187
query54	316	306	302	302
query55	88	86	83	83
query56	352	327	309	309
query57	1133	1192	1086	1086
query58	285	289	266	266
query59	2456	2511	2423	2423
query60	353	354	356	354
query61	169	166	162	162
query62	779	757	681	681
query63	234	190	200	190
query64	4449	1193	884	884
query65	4046	3945	3959	3945
query66	1102	445	328	328
query67	15165	15231	14989	14989
query68	4963	955	631	631
query69	508	339	301	301
query70	1273	1293	1284	1284
query71	428	328	315	315
query72	6110	5175	5127	5127
query73	632	582	373	373
query74	8696	8455	8494	8455
query75	3367	3378	2836	2836
query76	3268	1122	720	720
query77	531	394	306	306
query78	9603	9693	8881	8881
query79	2201	839	613	613
query80	1679	601	513	513
query81	585	269	235	235
query82	394	154	135	135
query83	367	265	251	251
query84	263	108	94	94
query85	941	501	444	444
query86	476	294	282	282
query87	3501	3571	3505	3505
query88	2847	2277	2271	2271
query89	377	324	291	291
query90	1921	228	224	224
query91	189	172	143	143
query92	92	71	63	63
query93	1943	1007	652	652
query94	775	465	341	341
query95	497	397	398	397
query96	501	569	279	279
query97	2873	2967	2882	2882
query98	238	214	211	211
query99	1297	1424	1262	1262
Total cold run time: 270309 ms
Total hot run time: 184356 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c6ec9efa77927e8790e9c5577b5c2086b3fd7f4, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.61	0.11	0.11
query5	0.27	0.24	0.25
query6	1.16	0.65	0.64
query7	0.03	0.02	0.02
query8	0.05	0.05	0.04
query9	0.58	0.51	0.52
query10	0.58	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	1.00	1.01	1.00
query15	0.85	0.84	0.87
query16	0.42	0.39	0.38
query17	1.04	1.04	1.01
query18	0.22	0.19	0.19
query19	1.89	1.80	1.80
query20	0.01	0.01	0.04
query21	15.45	0.19	0.13
query22	5.08	0.08	0.04
query23	15.65	0.25	0.10
query24	2.65	1.26	0.55
query25	0.06	0.06	0.06
query26	0.15	0.13	0.14
query27	0.07	0.05	0.06
query28	4.25	1.15	0.94
query29	12.56	3.96	3.29
query30	0.28	0.14	0.11
query31	2.81	0.59	0.39
query32	3.23	0.55	0.49
query33	3.00	3.02	3.06
query34	15.80	5.11	4.60
query35	4.58	4.55	4.59
query36	0.68	0.50	0.48
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 97.9 s
Total hot run time: 27.64 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 80.00% (8/10) 🎉
Increment coverage report
Complete coverage report

@suxiaogang223
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit e782626 into apache:master Nov 26, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 26, 2025
…8355)

### What problem does this PR solve?

Invoke logRefreshExternalTable whenever ALTER TABLE … EXECUTE finishes
so FE metadata stays in sync with external sources
yiguolei pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x-conflict dev/4.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants