[FLINK-37151][runtime-web] Remove redundant testing dependencies and files#25997
Merged
Sxnan merged 2 commits intoapache:release-1.20from Apr 2, 2025
Merged
[FLINK-37151][runtime-web] Remove redundant testing dependencies and files#25997Sxnan merged 2 commits intoapache:release-1.20from
Sxnan merged 2 commits intoapache:release-1.20from
Conversation
Collaborator
davidradl
reviewed
Jan 16, 2025
| "index": "src/index.html", | ||
| "main": "src/main.ts", | ||
| "polyfills": "src/polyfills.ts", | ||
| "polyfills": ["zone.js"], |
Contributor
There was a problem hiding this comment.
I am curious why you have made this change - as it is not a removal.
Contributor
Author
There was a problem hiding this comment.
hi @davidradl , thanks for your review!
This change is an equivalent replacement.
Since angular v17, the polyfills option can be simply set to zone.js if the duty of polyfills.ts is just to importing zone.js.
Contributor
|
Reviewed by Chi on 23/01/2025 Need a committer to review. From the WebUI area |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: issues.apache.org/jira/browse/FLINK-37151
What is the purpose of the change
Remove redundant testing dependencies and testing files, because they are useless.
Brief change log
@testing-library/angularkarmajasmineprotractor*.spec.tsVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation