Skip to content

Comments

[FLINK-37151][runtime-web] Remove redundant testing dependencies and files#25997

Merged
Sxnan merged 2 commits intoapache:release-1.20from
Laffery:FLINK-37151
Apr 2, 2025
Merged

[FLINK-37151][runtime-web] Remove redundant testing dependencies and files#25997
Sxnan merged 2 commits intoapache:release-1.20from
Laffery:FLINK-37151

Conversation

@Laffery
Copy link
Contributor

@Laffery Laffery commented Jan 16, 2025

JIRA Ticket: issues.apache.org/jira/browse/FLINK-37151

What is the purpose of the change

Remove redundant testing dependencies and testing files, because they are useless.

Brief change log

  • remove testing deps such as @testing-library/angular karma jasmine protractor
  • remove testing files *.spec.ts
  • remove other useless files and configuration

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 16, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

"index": "src/index.html",
"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"polyfills": ["zone.js"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why you have made this change - as it is not a removal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @davidradl , thanks for your review!

This change is an equivalent replacement.
Since angular v17, the polyfills option can be simply set to zone.js if the duty of polyfills.ts is just to importing zone.js.

@davidradl
Copy link
Contributor

Reviewed by Chi on 23/01/2025 Need a committer to review. From the WebUI area

Copy link
Contributor

@Sxnan Sxnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

@Sxnan Sxnan merged commit 8131ab7 into apache:release-1.20 Apr 2, 2025
@gmdfalk gmdfalk mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants