Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37151][runtime-web] Remove redundant testing dependencies and files #25997

Merged
merged 2 commits into from
Apr 2, 2025
+747 −1,129
Merged

[FLINK-37151][runtime-web] Remove redundant testing dependencies and files #25997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
763aa47
[FLINK-37151][runtime-web] Remove redundant testing dependencies and …
Laffery Jan 16, 2025
bf7cdf3
[FLINK-37151][runtime-web] Remove redundant testing dependencies and …
Laffery Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion flink-runtime-web/web-dashboard/.prettierignore
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
**/*.svg
**/test.ts
package.json
web/
node_modules/
1 change: 0 additions & 1 deletion flink-runtime-web/web-dashboard/.stylelintignore
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
**/*.svg
**/test.ts
package.json
web/
node_modules/
19 changes: 1 addition & 18 deletions flink-runtime-web/web-dashboard/angular.json
View file
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@
"outputPath": "web",
"index": "src/index.html",
"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"polyfills": ["zone.js"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why you have made this change - as it is not a removal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @davidradl , thanks for your review!

This change is an equivalent replacement.
Since angular v17, the polyfills option can be simply set to zone.js if the duty of polyfills.ts is just to importing zone.js.

"tsConfig": "src/tsconfig.app.json",
"assets": [
"src/assets",
@@ -114,23 +114,6 @@
"buildTarget": "flink:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "src/test.ts",
"polyfills": "src/polyfills.ts",
"tsConfig": "src/tsconfig.spec.json",
"karmaConfig": "src/karma.conf.js",
"styles": [
"src/styles/index.less"
],
"scripts": [],
"assets": [
"src/favicon.ico",
"src/assets"
]
}
},
"lint": {
"builder": "@angular-eslint/builder:lint",
"options": {
Loading