Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix esp spi slave receive data #14420

Conversation

FelipeMdeO
Copy link
Contributor

Note: Please adhere to Contributing Guidelines.

Summary

This PR fix know issue in esp32c6 spi slave driver. The issue was presented here: #13238

Also, this PR add spi slave configuration to esp32c6 devkitm

Impact

Now esp32c6 can get data received from spi master properly.

Testing

2 esp32c6 devikit m were used, one as master and other as slave. In image below you will see tests. In the right side master sends data to slave and in the left side slave, running a simple application, can read exactly data sent by master.
image

Tnx @Donny9 for improve and fix issues in top half layer.

@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Board: risc-v Size: L The size of the change in this PR is large labels Oct 21, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 21, 2024

[Experimental Bot, please feedback here]

Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.

The provided PR information seems to meet most of the NuttX requirements. However, it would benefit from slight improvements for better clarity and completeness.

Strengths:

  • Clear Summary: The summary explains the "why" (fixing a known issue), the "what" (fixing the esp32c6 SPI slave driver and adding configuration), and links the relevant issue.
  • Impact Description: It highlights the positive impact on functionality (esp32c6 can now receive data properly).
  • Testing Evidence: It mentions the testing setup (two esp32c6 devkit m boards) and provides visual proof of successful communication between master and slave.

Areas for Improvement:

  • Impact - Be More Specific:
    • While stating that "esp32c6 can now get data received properly" is good, elaborate on the impact in a bit more detail. For example:
      • "Previously, the esp32c6 SPI slave driver had an issue where [describe the exact issue - e.g., data was not being received consistently, there were errors, etc.]. This fix resolves this issue, enabling reliable SPI slave communication on the esp32c6."
    • Go through each impact category (build, hardware, documentation, security, compatibility) and explicitly state "NO" or provide a brief explanation if applicable.
  • Testing - Add Logs (If Possible):
    • While the image is helpful, consider including relevant code snippets or logs from both master and slave devices to demonstrate the data exchange. This provides more concrete evidence of the fix. If logs are too long, consider adding them as a separate file in the PR.

Example of Improved Impact Section:

## Impact

* **Is new feature added?** NO
* **Is existing feature changed?** YES, the esp32c6 SPI slave driver is fixed.
* **Impact on user:** YES, users can now reliably use the esp32c6 as an SPI slave device.  Prior to this fix, the driver had issues with [describe the specific issue], preventing proper data reception.
* **Impact on build:** NO
* **Impact on hardware:** NO 
* **Impact on documentation:**  YES, the esp32c6 devkitm configuration now includes SPI slave settings, requiring documentation updates to reflect this.
* **Impact on security:** NO
* **Impact on compatibility:** NO
* **Anything else to consider:**  N/A

By making these improvements, the PR will be more comprehensive, informative, and easier for reviewers to assess.

@FelipeMdeO FelipeMdeO force-pushed the bugfix/fix-esp-spi-slave-receive-data branch 2 times, most recently from 1446ed7 to f20b765 Compare October 21, 2024 03:17
@github-actions github-actions bot removed Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: simulator Issues related to the SIMulator labels Oct 21, 2024
@FelipeMdeO FelipeMdeO force-pushed the bugfix/fix-esp-spi-slave-receive-data branch from f20b765 to 1e2e475 Compare October 21, 2024 03:24
@github-actions github-actions bot added Size: M The size of the change in this PR is medium and removed Area: Documentation Improvements or additions to documentation Size: L The size of the change in this PR is large labels Oct 21, 2024
@xiaoxiang781216 xiaoxiang781216 linked an issue Oct 21, 2024 that may be closed by this pull request
1 task
@xiaoxiang781216 xiaoxiang781216 merged commit 0496f35 into apache:master Oct 21, 2024
17 checks passed
@FelipeMdeO FelipeMdeO deleted the bugfix/fix-esp-spi-slave-receive-data branch November 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Board: risc-v Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ESP32C6 Slave Driver Issue
3 participants