RANGER-5322: PolicyRefresher can struck with no download thread if exception thrown in startRefresher #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ception thrown in startRefresher
dhavalshah9131
requested review from
dineshkumar-yadav,
kishorgollapalliwar,
kumaab,
mneethiraj and
pradeepagrawal8184
mneethiraj
reviewed
Sep 15, 2025
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
Outdated
Show resolved
Hide resolved
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
Outdated
Show resolved
Hide resolved
|
I updated the PR after further debugging and found that both loadRoles() and loadPolicy() handle all exceptions internally without throwing any. While the code isn't very clean or readable, it is correct. In this PR, I fixed a couple of minor issues and added tests to cover the scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Handled the exception thrown in loadRoles() and loadPolicy()
How was this patch tested?
run mvn clean install and all tests are clean.